feat: ✨ add spaPageview support #4
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## development #4 +/- ##
===============================================
- Coverage 87.09% 83.33% -3.77%
===============================================
Files 4 5 +1
Lines 31 36 +5
Branches 3 3
===============================================
+ Hits 27 30 +3
- Misses 4 6 +2 ☔ View full report in Codecov by Sentry. |
HofmannZ
force-pushed
the
@HofmannZ/feature/spa-pageview
branch
from
48735de to
6a95ff2
Compare
UralKrc
reviewed
Apr 10, 2024
| @@ -29,6 +29,9 @@ export function getZaraz() { | |||
| ecommerce: (...args: unknown[]) => { | |||
| queue.push({ method: 'ecommerce', arguments: args }); | |||
| }, | |||
| spaPageview: (...args: unknown[]) => { | |||
There was a problem hiding this comment.
not related with this PR but should we also add consent here?
There was a problem hiding this comment.
Would be really tricky to queue that. The consent API also has some getters instead of only setters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for the new
spaPageviewmethod. It can be used to manually trigger a pageview without having to access Zaraz internals likezarazData.l,zarazData.t, orzaraz.__zarazMCListeners.