PR from E2552 to E2557 #223

deekshithanantha · 2025-10-28T21:38:05Z

No description provided.

…ersion to 6.0

…we updated the puma version

credits to csingha - Introduced role hierarchy creation for users (Super Administrator, Administrator, Instructor, Teaching Assistant, Student). - Streamlined user creation process for instructors and students. - Added error handling for database seeding to provide clearer messages. - Improved code organization and readability by removing redundant comments and restructuring the flow.

commit f608218 Author: dmpatel3 <[email protected]> Date: Wed Apr 16 22:13:20 2025 -0400 Renamed find_team_users() to find_project_topic_team_users() and adjusted SignedUpTeam tests accordingly commit 615c2b7 Author: smiti <[email protected]> Date: Thu Apr 17 06:37:54 2025 +0530 add new tests and comments for project_topic and signed_up_team. commit 54656ae Author: smiti <[email protected]> Date: Wed Apr 16 10:41:57 2025 +0530 add new function in signed up team and its tests. commit 4b4eb90 Merge: a351623 0e067e0 Author: Adithya Srinivasan <[email protected]> Date: Mon Mar 24 17:07:24 2025 -0400 Merge branch 'main' of https://github.com/RandomOscillations/reimplementation-back-end commit a351623 Author: Adithya Srinivasan <[email protected]> Date: Mon Mar 24 17:05:06 2025 -0400 Added JSON parsing in project_topic_controller_spec.rb commit 0e067e0 Author: smiti <[email protected]> Date: Tue Mar 25 01:41:31 2025 +0530 fix the code commit 0faeb33 Author: smiti <[email protected]> Date: Mon Mar 24 09:07:34 2025 +0530 fixed the routing test file commit f6a4774 Author: dmpatel3 <[email protected]> Date: Sun Mar 23 21:54:21 2025 -0400 Added and modified tests for the ProjectTopic controller commit acecf6b Author: smiti <[email protected]> Date: Mon Mar 24 04:58:41 2025 +0530 made necessary changes commit 2793616 Author: smiti <[email protected]> Date: Sat Mar 22 05:20:54 2025 +0530 add tests and code for model commit 8ed7a4a Author: smiti <[email protected]> Date: Sat Mar 22 05:20:37 2025 +0530 add tests commit 6c0dbec Author: dmpatel3 <[email protected]> Date: Thu Mar 20 18:17:26 2025 -0400 Refactored remaining SignUpTopic-related instances across the project to ProjectTopic-related instances commit c242e16 Author: smiti <[email protected]> Date: Thu Mar 20 05:05:37 2025 +0530 refactored the project_topic model. commit 39df8eb Author: smiti <[email protected]> Date: Wed Mar 19 07:31:00 2025 +0530 Added migration file and renamed sign_up_topic to project_topic

…tency - Updated `signup_team` method to `sign_team_up` in ProjectTopic for improved readability. - Adjusted references in SignedUpTeam to call the renamed method. - Fixed DRY violation. - Commented out fixture path in RSpec configuration to resolve errors. - Updated tests to reflect method name changes and ensure proper functionality.

…tation-back-end

- Removed the API namespace from ProjectTopicsController for simplified routing. - Updated the index action comment to reflect the new endpoint structure.

- Updated ProjectTopicsController to include calculated fields in the response for project topics. - Added new methods in SignedUpTeamsController for dropping topics and teams from topics, with appropriate error handling and responses. - Refactored SignedUpTeam model to streamline the creation and deletion of signed up teams. - Updated routes to include new endpoints for dropping topics and teams. - Enhanced db/seeds.rb to create sample project topics and a test student user for easier testing.

…oved functionality - Updated ProjectTopicsController to utilize new model methods for creating, updating, and deleting project topics, enhancing code clarity and maintainability. - Refactored SignedUpTeamsController to streamline team signup and topic management processes, incorporating new business logic methods from the SignedUpTeam model. - Enhanced error handling and response messages for better API usability. - Added JSON serialization for project topics to include computed data in responses, reducing frontend processing needs.

github-actions · 2025-10-28T21:38:19Z

	2 Warnings
⚠️	Pull request is too big (more than 500 LoC).
⚠️	RSpec tests seem shallow (single `it` blocks or no context). Consider improving test structure.

Generated by 🚫 Danger

…ment functionality - Added methods to get a user's team for a specific assignment and ensure a team exists for the assignment, enhancing the signup process. - Updated the sign-up logic to utilize the new methods for better handling of team assignments. - Modified the seeds file to create TeamsParticipant records, streamlining the assignment of students to teams.

github-actions · 2025-11-11T16:31:22Z

🚨 RSpec Tests Report

All tests passed.

vihar2712 · 2025-11-26T18:23:42Z

app/models/project_topic.rb

+  end
+
+  # Business logic for creating a project topic
+  def self.create_topic_with_assignment(topic_params, assignment_id, micropayment = nil)


the method needs to be removed. the create method inside the controller will be sufficient enough

vihar2712 · 2025-11-26T18:24:32Z

app/controllers/project_topics_controller.rb

+    result = ProjectTopic.create_topic_with_assignment(
+      project_topic_params, 
+      params[:project_topic][:assignment_id], 
+      params[:micropayment]


no need for micropayment field

vihar2712 · 2025-11-26T18:26:02Z

app/controllers/project_topics_controller.rb

+
+  # Destroy ProjectTopics by assignment_id and optional topic_ids
+  def destroy
+    if params[:assignment_id].nil?


don't need this check, the project topic always belong to an assignment

vihar2712 · 2025-11-26T18:29:22Z

app/controllers/project_topics_controller.rb

+    if params[:assignment_id].nil?
+      render json: { message: 'Assignment ID is required!' }, status: :unprocessable_entity
+    else
+      result = ProjectTopic.delete_by_assignment_and_topic_ids(params[:assignment_id], params[:topic_ids])


need to loop over all topic ids and call delete method for each topic id

vihar2712 · 2025-11-26T18:36:40Z

app/models/project_topic.rb

+  belongs_to :assignment
+
+  # Ensures the number of max choosers is non-negative
+  validates :max_choosers, numericality: {


consider num_slots instead of max_choosers for project_topic

vihar2712 · 2025-11-27T15:34:08Z

app/models/signed_up_team.rb

+  end
+
+  # Business logic for getting team participants for a topic
+  def self.get_team_participants_for_topic(topic_id)


redundant methods. remove it

vihar2712 · 2025-11-27T15:34:58Z

app/models/signed_up_team.rb

+  private
+
+  # Helper method to drop existing signups for a team
+  def self.drop_existing_signups_for_team(team_id)


it should be instance method instead of class method,

vihar2712 · 2025-11-27T15:35:34Z

app/models/signed_up_team.rb

+  end
+
+  # Business logic for dropping a topic for a student
+  def self.drop_topic_for_student(user_id, topic_id)


can be instance method for project_topic, not signed_up_team

vihar2712 · 2025-11-27T15:36:04Z

app/models/signed_up_team.rb

+  end
+
+  # Returns all users in a given team that's signed up for a topic
+  def self.find_project_topic_team_users(team_id)


no need of this method. teams_users no longer exist

vihar2712 · 2025-11-27T15:37:04Z

app/models/signed_up_team.rb

+    team = Team.find_by(id: team_id)
+    return [] unless team
+
+    team.users.to_a


teams_users no longer exist. make it use teams_participants

abhira0 and others added 12 commits October 25, 2025 19:20

due to compatiblity issue while setting up, we have to bump up puma v…

bf07582

…ersion to 6.0

auto updated after running docker compose, but this happened because …

79b1cfa

…we updated the puma version

fixed the issue with logging in

2a84b20

Merge branch 'main' of https://github.com/deekshithanantha/reimplemen…

10a6cdc

…tation-back-end

Refactor ProjectTopicsController and clean up schema.rb

bea6385

- Removed the API namespace from ProjectTopicsController for simplified routing. - Updated the index action comment to reflect the new endpoint structure.

updaet dthe seed file to add project topics

0b97d14

allow enabling bookmarks in the assignment edit

c9f4dbc

deekshithanantha closed this Oct 28, 2025

deekshithanantha reopened this Oct 28, 2025

abhira0 added 5 commits October 30, 2025 13:10

udpated seeds to use faker

e627fb8

allow more params while updating project topic

8e1d078

creating 5 students

eb67061

fixing tests

f9ee2fc

vihar2712 marked this pull request as ready for review November 12, 2025 18:51

vihar2712 requested changes Nov 27, 2025

View reviewed changes

PR from E2552 to E2557 #223

Are you sure you want to change the base?

PR from E2552 to E2557 #223

Uh oh!

Conversation

deekshithanantha commented Oct 28, 2025

Uh oh!

github-actions bot commented Oct 28, 2025

Uh oh!

github-actions bot commented Nov 11, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants