E2550 Response hierarchy and responses_controller back end #227

bestinlalu · 2025-10-29T03:53:59Z

This PR focuses on improving the Response system within Expertiza, which handles how peer reviews, teammate evaluations, and other questionnaire-based responses are stored and managed. Previously, response handling was scattered across different map controllers (e.g., ReviewResponseMap, TeammateReviewResponseMap), so the goal of this project is to centralize and standardize response management through enhancements to the Response model and the creation of a new ResponsesController on the back end.

Wiki Link: https://github.com/bestinlalu/reimplementation-back-end/wiki/Background

Response Type Mapping

…ser responses.

…-back-end into ScoreLogic

… all APIs and testing done using rspec

[#4, #5, #6, #7, #8, #9, #20] Implement ResponseController class with all APIs and testing done using rspec

…-back-end into ScoreLogic

…-back-end into ScoreLogic Adding controller updates to the ScoreLogic

Implemented name link from Edit to Update

Removed save_draft endpoint, Removed using Reviewer role, Updated rspec

edited case descriptions

Removing mock data from rails_helper

Code clean up, removing output statements

Increase puma version to 6.4.2

github-actions · 2025-10-29T05:35:49Z

	3 Warnings
⚠️	Pull request is too big (more than 500 LoC).
⚠️	Pull request has duplicated commit messages.
⚠️	RSpec tests seem shallow (single `it` blocks or no context). Consider improving test structure.

Generated by 🚫 Danger

Update the swagger with new response endpoints

…-back-end

github-actions · 2025-11-04T16:43:23Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:47 # Response#calculate_total_score computes the total score of a review
rspec ./spec/models/response_spec.rb:124 # Response#calculate_total_score (weighted) adds weight * answer for scorable items
rspec ./spec/models/response_spec.rb:145 # Response#calculate_total_score (skips non-scorable and nil) ignores items that are not scorable and answers that are nil

github-actions · 2025-11-04T17:02:49Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:47 # Response#calculate_total_score computes the total score of a review
rspec ./spec/models/response_spec.rb:124 # Response#calculate_total_score (weighted) adds weight * answer for scorable items
rspec ./spec/models/response_spec.rb:145 # Response#calculate_total_score (skips non-scorable and nil) ignores items that are not scorable and answers that are nil

github-actions · 2025-11-04T17:07:06Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:47 # Response#calculate_total_score computes the total score of a review
rspec ./spec/models/response_spec.rb:124 # Response#calculate_total_score (weighted) adds weight * answer for scorable items
rspec ./spec/models/response_spec.rb:145 # Response#calculate_total_score (skips non-scorable and nil) ignores items that are not scorable and answers that are nil

github-actions · 2025-11-05T01:23:21Z

🚨 RSpec Tests Report

Failing Model Test Cases:
rspec ./spec/models/response_spec.rb:47 # Response#calculate_total_score computes the total score of a review
rspec ./spec/models/response_spec.rb:124 # Response#calculate_total_score (weighted) adds weight * answer for scorable items
rspec ./spec/models/response_spec.rb:145 # Response#calculate_total_score (skips non-scorable and nil) ignores items that are not scorable and answers that are nil

Score calculation test cases clean up

github-actions · 2025-11-05T03:32:40Z

🚨 RSpec Tests Report

All tests passed.

github-actions · 2025-11-05T06:12:58Z

🚨 RSpec Tests Report

All tests passed.

efg

Lots of low-level issues to handle and fix.

efg · 2025-11-10T19:00:22Z

app/controllers/responses_controller.rb

+      true
+    when 'update', 'submit'
+      @response = Response.find(params[:id])
+      unless owns_response_or_map? || has_role?('Instructor') || has_role?('Admin')


The disjunction should be replaced by ~ has_privileges_of

efg · 2025-11-10T19:01:12Z

app/controllers/responses_controller.rb

+        render json: { error: 'forbidden' }, status: :forbidden
+      end
+    when 'unsubmit', 'destroy'
+      unless has_role?('Instructor') || has_role?('Admin')


Shouldn't it also check to make sure this is the instructor's (or the admin's) assignment? Shouldn't be able to delete reviews for other people's assignments.

efg · 2025-11-10T19:04:28Z

app/controllers/responses_controller.rb

+    return render json: { error: 'Response already submitted' }, status: :unprocessable_entity if @response.is_submitted?
+
+    # Check deadline
+    return render json: { error: 'Deadline has passed' }, status: :forbidden unless deadline_open?(@response)


deadline_open? is a bad name. What does that mean?

efg · 2025-11-10T19:05:56Z

app/controllers/responses_controller.rb

+    return render json: { error: 'Deadline has passed' }, status: :forbidden unless deadline_open?(@response)
+
+    # Validate rubric completion
+    unanswered = @response.scores.select { |a| a.answer.nil? }


It is just WRONG to build into the mechanism that ALL rubric items must have text (or numbers) entered for ALL rubrics of ANY KIND anywhere in the system. This should be dependent on policy. Remove this check.

efg · 2025-11-10T19:07:54Z

app/controllers/responses_controller.rb

+
+    if @response.is_submitted?
+      @response.update(is_submitted: false)
+      render json: { message: 'Response reopened for revision', response: @response }, status: :ok


The word "Response" here could be confusing. That's what it is in the system, but the UI should use better names. Don't we have print names for each different kind of Questionnaire? Also, "reopened for revision" is much too cryptic. Say it in plain English!

efg · 2025-11-10T19:25:40Z

app/models/response_map.rb

+    return nil unless reviewee
+
+    candidates = []
+    candidates << reviewee.updated_at if reviewee.respond_to?(:updated_at) && reviewee.updated_at.present?


respond_to? is confusing; that method should be renamed to something that is more suggestive of what it does.

app/models/response_map.rb

Changes as per few review comments in the response_controller

Pr fixes related to response type mapping

Changes as per few review comments in the response_controller

…and clarified comments

Updated response specs and clarified response_map helpers

…prove user messages

efg

Thanks for fixing!

efg · 2025-12-01T18:49:53Z

app/controllers/responses_controller.rb

+      true
+    when 'update', 'submit'
+      @response = Response.find(params[:id])
+      unless response_belongs_to? || current_user_has_admin_privileges? || 


It's not whether current_user_has_admin_privileges?; it's whether this user created (is the parent of) the instructor whose course this is. One of the current projects is writing/has written code for this. Not sure which, but it should be fairly easy to guess.

efg · 2025-12-01T18:53:45Z

app/controllers/responses_controller.rb

+  # Checks whether the current_user is the instructor for the assignment
+  # associated with the response identified by params[:id].
+  # Uses the shared authorization method from Authorization concern.
+  def current_user_instructs_response_assignment?


Not only the instructor, but also TAs for the course and the admin who created the instructor, need to be able to perform this method.

efg · 2025-12-01T18:55:16Z

app/controllers/responses_controller.rb

+    return true if assignment.nil?
+    return true if assignment.due_dates.nil?
+
+    # Check if due_date has a future? method, otherwise compare timestamps


I think there is an "upcoming" method that does what you think future? does.

I think "upcoming" is a better name.

It's E2566, finish DueDates, who is using the upcoming method.

efg · 2025-12-01T18:59:08Z

app/models/response.rb

+    # (each response can omit questions, so maximum_score may differ and we normalize before averaging)
    existing_responses.each do |response|
      unless id == response.id # the current_response is also in existing_responses array
        count += 1


Should this be in the ReviewAggregator mixin?

efg · 2025-12-01T19:00:46Z

app/models/response.rb

      unless id == response.id # the current_response is also in existing_responses array
        count += 1
-        total +=  response.aggregate_questionnaire_score.to_f / response.maximum_score
+        total += response.aggregate_questionnaire_score.to_f / response.maximum_score


Please remove the code smell.

…s; prefer upcoming for deadlines; reduce rounding in report diffs

Yu Wang and others added 25 commits October 26, 2025 12:43

Added response type mapping hash, response.kind_name and unit tests

7e593fa

Merge pull request #21 from bestinlalu/feature/response-type-mapping

05ce778

Response Type Mapping

Updated score calculation logic to ensure accurate scoring based on u…

21c2f4c

…ser responses.

Merge branch 'main' of https://github.com/bestinlalu/reimplementation…

f903ff4

…-back-end into ScoreLogic

[#4, #5, #6, #7, #8, #9, #20] Implement ResponseController class with…

dfba845

… all APIs and testing done using rspec

Merge pull request #22 from bestinlalu/issue-4

a9732e4

[#4, #5, #6, #7, #8, #9, #20] Implement ResponseController class with all APIs and testing done using rspec

Merge branch 'main' of https://github.com/bestinlalu/reimplementation…

1067bc9

…-back-end into ScoreLogic

Merge branch 'main' of https://github.com/bestinlalu/reimplementation…

a7b4311

…-back-end into ScoreLogic Adding controller updates to the ScoreLogic

Updated test for deadline and update link logic

ab3abbc

Removed the next action api

778de56

Added the tests for the update logic

4c101db

removed next action

ea4eaae

Merge pull request #23 from bestinlalu/ScoreLogic

77138e3

Implemented name link from Edit to Update

Removed save_draft endpoint, Removed using Reviewer role, Updated rspec

b0aec87

Merge branch 'main' into issue-4

a1c620d

Merge pull request #24 from bestinlalu/issue-4

8bb157c

Removed save_draft endpoint, Removed using Reviewer role, Updated rspec

Adding comment for test cases in kind name spec

9535b2f

edited case descriptions

ec5e0ab

Merge pull request #25 from bestinlalu/feature/response-type-mapping

e5bb8e4

edited case descriptions

Removing mock data from rails_helper

d268e98

Merge pull request #26 from bestinlalu/final-tweaks

1015d4c

Removing mock data from rails_helper

Code clean up, removing output statements

9222eb7

Merge pull request #27 from bestinlalu/final-tweaks

fdc02a1

Code clean up, removing output statements

Increase puma version to 6.4.2

3178c85

Merge pull request #28 from bestinlalu/final-tweaks

d79fe2a

Increase puma version to 6.4.2

bestinlalu and others added 4 commits October 29, 2025 02:00

Update the swagger with new response endpoints

aff9052

Merge pull request #29 from bestinlalu/final-tweaks

11f4634

Update the swagger with new response endpoints

Added small tweeks to comments for clarity and completeness.

b1de8bd

Merge branch 'main' of https://github.com/bestinlalu/reimplementation…

281f33f

…-back-end

Commented out the 80th line as requested

02d702d

fix model tests error for PR expertiza#227

f49b5d3

bestinlalu and others added 2 commits November 4, 2025 22:17

Score calculation test cases clean up

fb9b315

Merge pull request #30 from bestinlalu/final-tweaks

afa1c61

Score calculation test cases clean up

vihar2712 self-requested a review November 10, 2025 18:49

vihar2712 approved these changes Nov 10, 2025

View reviewed changes

efg requested changes Nov 10, 2025

View reviewed changes

bestinlalu and others added 10 commits November 13, 2025 14:05

Changes as per few review comments in the response_controller

005c1ac

Merge pull request #31 from bestinlalu/final-tweaks

391d244

Changes as per few review comments in the response_controller

done requested changes related to response type mapping

7377636

Merge pull request #32 from bestinlalu/pr-fixes

6de4fe3

Pr fixes related to response type mapping

Changes as per few review comments in the response_controller

8fcb4ae

Merge pull request #33 from bestinlalu/final-tweaks

75bfed7

Changes as per few review comments in the response_controller

1. updated Response controller specs 2. renamed response map helpers …

a166726

…and clarified comments

Merge pull request #34 from bestinlalu/pr-fixes

921b75e

Updated response specs and clarified response_map helpers

Merge branch 'main' into main

d0f2c54

Refactor responses_controller: Add assignment ownership checks and im…

d913551

…prove user messages

efg reviewed Dec 1, 2025

View reviewed changes

Auth: allow instructor, TA, and parent-admin; use questionnaire label…

8349a11

…s; prefer upcoming for deadlines; reduce rounding in report diffs

E2550 Response hierarchy and responses_controller back end #227

Are you sure you want to change the base?

E2550 Response hierarchy and responses_controller back end #227

Uh oh!

Conversation

bestinlalu commented Oct 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 4, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

github-actions bot commented Nov 5, 2025

Uh oh!

efg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

efg left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

bestinlalu commented Oct 29, 2025 •

edited

Loading