E2561. Finish up SubmittedContentController #228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ts for submitted content API
Fix Download action test cases
Generated by 🚫 Danger |
vihar2712
reviewed
Dec 15, 2025
|
|
||
| # Validate that the hyperlink is not blank | ||
| if submit_link.blank? | ||
| return render_error('Hyperlink submission cannot be blank. Please provide a valid URL.', :bad_request) |
Collaborator
There was a problem hiding this comment.
use validates_url gem to validate the submitted hyperlink
vihar2712
reviewed
Dec 15, 2025
| end | ||
|
|
||
| # Validate file extension against allowed types | ||
| unless valid_file_extension?(uploaded_file_name(uploaded)) |
Collaborator
There was a problem hiding this comment.
better to remove this check
vihar2712
reviewed
Dec 15, 2025
| @@ -0,0 +1,38 @@ | |||
| module FileHelper | |||
| extend self | |||
| # Replace invalid characters with underscore | |||
Collaborator
There was a problem hiding this comment.
"replace whitespace characters" would make much more sense
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.