Skip to content

Handle Non result#13

Closed
hugo-syn wants to merge 1 commit intoexploide:mainfrom
hugo-syn:patch-1
Closed

Handle Non result#13
hugo-syn wants to merge 1 commit intoexploide:mainfrom
hugo-syn:patch-1

Conversation

@hugo-syn
Copy link
Copy Markdown

No description provided.

@exploide
Copy link
Copy Markdown
Owner

exploide commented Apr 29, 2026

Hi, thanks for your PR. Do you know in which situation the result can be None? The lines immediately following your change suggest that it already handles no matching object names. Maybe the API changed?
Will take a look once I find some time.

@hugo-syn
Copy link
Copy Markdown
Author

Honestly I don't know I got this stack trace and added the check, it fixed my issue. It's customer data so I can't share it but if you know what to look for I can try to add some debug info to pinpoint the issue :)

@exploide
Copy link
Copy Markdown
Owner

exploide commented May 5, 2026

Had time to look into this and you are right, this issue is reproducible. Turns out the API has changed. 🙄
In the past /api/v2/search returned an empty list when nothing was found. Now they return null 🤷‍♂️

A bit annoying and I would have preferred the old behavior but at least it is easy to fix.

However, the fix needs to be in another place. Not only the mark subcommand is affected.
I will push a fix, add test cases and close this PR.

Nevertheless, thanks for pointing out this issue! 😃

@exploide exploide closed this in 139418c May 5, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants