-
Notifications
You must be signed in to change notification settings - Fork 44
Review supported Python versions and platforms #130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -22,8 +22,24 @@ jobs: | |
| strategy: | ||
| fail-fast: true | ||
| matrix: | ||
| os: [ubuntu-latest, windows-2022] | ||
| python_version: ["3.9", "3.10", "3.11", "3.12"] | ||
| os: | ||
| - ubuntu-latest # x64 | ||
| - ubuntu-24.04-arm # ARM | ||
| - macos-15-intel # x64 | ||
| - macos-latest # ARM | ||
| - windows-latest # x64 | ||
| python_version: ["3.10", "3.11", "3.12", "3.13", "3.14"] | ||
| cc: [''] # default: gcc on Linux; clang on Mac/Windows | ||
| include: | ||
| # Note: default compiler for Linux is gcc. cibuildwheel uses gcc. | ||
| # FIXME: clang crashes on ARM Linux | ||
| - os: ubuntu-latest | ||
| python_version: "3.10" | ||
| cc: clang | ||
| - os: ubuntu-latest | ||
| python_version: "3.14" | ||
| cc: clang | ||
|
|
||
| runs-on: ${{ matrix.os }} | ||
|
|
||
| steps: | ||
|
|
@@ -34,7 +50,6 @@ jobs: | |
| uses: actions/setup-python@v6 | ||
| with: | ||
| python-version: ${{ matrix.python_version }} | ||
| architecture: x64 | ||
|
|
||
| # Install LLVM 18 on Windows | ||
| - name: Install LLVM 18 on Windows | ||
|
|
@@ -52,18 +67,6 @@ jobs: | |
| run: | | ||
| dir "C:\Program Files (x86)\Microsoft Visual Studio\2019\Enterprise\VC\Auxiliary\Build" /b | ||
|
|
||
| set "PATH=C:\\Program Files\\LLVM\\bin;%PATH%" | ||
| set "AR=llvm-ar" | ||
| set "AS=llvm-as" | ||
| set "CC=clang" | ||
| set "RANLIB=echo" | ||
| call "C:\\Program Files (x86)\\Microsoft Visual Studio\\2019\\Enterprise\VC\Auxiliary\Build\vcvarsall.bat" amd64 | ||
| clang --version | ||
| python -m build --wheel | ||
| shell: cmd | ||
| - name: Build wheel (Windows) | ||
| if: startsWith(matrix.os, 'windows') | ||
| run: | | ||
| set "PATH=C:\Program Files\LLVM\bin;%PATH%" | ||
| set "AR=llvm-ar" | ||
| set "AS=llvm-as" | ||
|
|
@@ -76,42 +79,22 @@ jobs: | |
|
|
||
| - name: Build wheel (Mac) | ||
| if: startsWith(matrix.os, 'macos') | ||
| run: | | ||
| python -m build --wheel | ||
|
|
||
| - name: Build wheel (Linux / clang) | ||
| if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.6' | ||
| run: | | ||
| clang --version | ||
| CC=clang python -m build --wheel | ||
| python -m build --wheel | ||
|
|
||
| - name: Build wheel (Linux / gcc-9) | ||
| if: startsWith(matrix.os, 'ubuntu') && (matrix.python_version == '3.7' || matrix.python_version == '3.8') | ||
| - name: Build wheel (Linux / gcc) | ||
| if: startsWith(matrix.os, 'ubuntu') && matrix.cc == '' | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install gcc-9 | ||
| gcc-9 --version | ||
| CC=gcc-9 python -m build --wheel | ||
| gcc --version | ||
| python -m build --wheel | ||
|
|
||
| - name: Build wheel (Linux / gcc-10) | ||
| if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.9' | ||
| run: | | ||
| sudo apt update | ||
| sudo apt install gcc-10 | ||
| gcc-10 --version | ||
| CC=gcc-10 python -m build --wheel | ||
| - name: Build wheel (Linux / clang-13) | ||
| if: startsWith(matrix.os, 'ubuntu') && matrix.python_version == '3.10' | ||
| - name: Build wheel (Linux / clang) | ||
| if: startsWith(matrix.os, 'ubuntu') && matrix.cc == 'clang' | ||
| run: | | ||
| clang --version | ||
| CC=clang python -m build --wheel | ||
|
Comment on lines
80
to
96
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This section is slightly more verbose than it could be, for the sake of readibility. |
||
|
|
||
| - name: Build wheel (Linux / gcc) | ||
| if: startsWith(matrix.os, 'ubuntu') && (matrix.python_version == '3.11' || matrix.python_version == '3.12') | ||
| run: | | ||
| gcc --version | ||
| CC=gcc python -m build --wheel | ||
|
|
||
| # TODO: install mypy from requirements if reenabled | ||
| - name: Run mypy | ||
| shell: bash | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -6,7 +6,7 @@ blis/cy.c | |
| blis/py.c | ||
| .eggs | ||
| .env/ | ||
| env3.6 | ||
| env/ | ||
| .hypothesis/ | ||
| build/ | ||
| cache/ | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,2 @@ | ||
| # build version constraints for use with wheelwright + multibuild | ||
| numpy==1.15.0; python_version<='3.7' and platform_machine!='aarch64' | ||
| numpy==1.19.2; python_version<='3.7' and platform_machine=='aarch64' | ||
| numpy==1.17.3; python_version=='3.8' and platform_machine!='aarch64' | ||
| numpy==1.19.2; python_version=='3.8' and platform_machine=='aarch64' | ||
| numpy>=2.0.0,<3.0.0; python_version>='3.9' | ||
| numpy>=2.0.0,<3.0.0 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,6 +1,5 @@ | ||
| # Test requirements | ||
| numpy>=1.15.0; python_version < "3.9" | ||
| numpy>=1.19.0; python_version >= "3.9" | ||
| numpy>=1.21.2 | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is the oldest numpy that supports python 3.10 |
||
| pytest | ||
| cython>=3.0,<4.0 | ||
| hypothesis>=4.0.0,<7.0.0 | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This was duplicated