Remove -march=knl flag for GCC 15 and LLVM 19 compatibility#154
Merged
Conversation
GCC 15 dropped support for Xeon Phi (KNL) targets, making -march=knl invalid. For optimized KNL kernels, remove -march=knl since -mavx512f is already specified explicitly. For reference kernels, replace -march=knl with -march=skylake to provide an AVX2 baseline (AVX-512 is then disabled via -mno-avx512f -mno-avx512cd). Follows the same approach as PR 129 which removed -mavx512pf. Closes explosiongh-150 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Contributor
Author
|
It's not just GCC 15, there are also warnings in the Windows logs for LLVM 19: |
rgommers
changed the title
Contributor
Author
|
This should be a straightforward fix and CI is green, so I'll put this in. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GCC 15 dropped support for Xeon Phi (KNL) targets, making -march=knl invalid. For optimized KNL kernels, remove -march=knl since -mavx512f is already specified explicitly. For reference kernels, replace -march=knl with -march=skylake to provide an AVX2 baseline (AVX-512 is then disabled via -mno-avx512f -mno-avx512cd).
Follows the same approach as PR 129 which removed -mavx512pf.
Closes gh-150