[eas-cli] [ENG-9957] Don't overwrite distribution for simulator builds (

#2073) * [eas-cli] Update dependencies Updated eas-build-job to new version See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Don't overwrite distribution Stops overwriting distribution type for simulator builds, and sets simulator field in metadata instead See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Merge main Merged changes from main branch See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Check for simulator flag Updated build:run command to use simulator flag instead of overwritten distribution type See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Update schema Update graphql schema with simulator fields See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Add flag Add simulator flag to build:list command See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Fix check Fixed check function with correct field name See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Fix tests Fixed failing tests after BuildFragment structure changed See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Add warning Added warning to build:list command that the distribution=simulator is deprecated See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Add description Added description to the new simulator flag See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Add validation Added validation so the simulator flag can only be used with --platofrm=ios See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Change message Updated the warning displayed when using deprecated --distribution=simulator flag value See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Replace string Replaced hardcoded string with variable See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Remove redundant check Removed no longer necessary check for simulator build See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Update schema Updated graphql schema after recent changes See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * [eas-cli] Update schema Updated graphql schema after recent changes See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds * update CHANGELOG.md * [eas-cli] Update schema Updated graphql schema after recent changes See: https://linear.app/expo/issue/ENG-9957/fix-internal-distribution-pages-for-simulator-builds
expo · Jan 31, 2024 · 315b5b2 · 315b5b2
1 parent ceb561a
commit 315b5b2
Show file tree

Hide file tree

Showing 11 changed files with 274 additions and 20 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -12,6 +12,8 @@ This is the log of notable changes to EAS CLI and related packages.
 
 ### 🧹 Chores
 
+- Add simulator flag to metadata. ([#2073](https://github.com/expo/eas-cli/pull/2073) by [@radoslawkrzemien](https://github.com/radoslawkrzemien))
+
 ## [7.1.2](https://github.com/expo/eas-cli/releases/tag/v7.1.2) - 2024-01-30
 
 ### 🧹 Chores

diff --git a/packages/eas-cli/graphql.schema.json b/packages/eas-cli/graphql.schema.json
diff --git a/packages/eas-cli/src/build/__tests__/cancel-test.ts b/packages/eas-cli/src/build/__tests__/cancel-test.ts
@@ -92,5 +92,6 @@ function createMockBuildFragment({
     },
     status: BuildStatus.InQueue,
     resourceClass: BuildResourceClass.AndroidMedium,
+    isForIosSimulator: false,
   };
 }
diff --git a/packages/eas-cli/src/build/__tests__/delete-test.ts b/packages/eas-cli/src/build/__tests__/delete-test.ts
@@ -92,5 +92,6 @@ function createMockBuildFragment({
     },
     status: BuildStatus.InQueue,
     resourceClass: BuildResourceClass.AndroidMedium,
+    isForIosSimulator: false,
   };
 }
diff --git a/packages/eas-cli/src/build/metadata.ts b/packages/eas-cli/src/build/metadata.ts
@@ -8,6 +8,7 @@ import { maybeResolveVersionsAsync as maybeResolveAndroidVersionsAsync } from '.
 import { BuildContext } from './context';
 import { maybeResolveVersionsAsync as maybeResolveIosVersionsAsync } from './ios/version';
 import { LocalBuildMode } from './local';
+import { BuildDistributionType } from './types';
 import Log from '../log';
 import {
   getUsername,
@@ -28,10 +29,7 @@ export async function collectMetadataAsync<T extends Platform>(
   ctx: BuildContext<T>
 ): Promise<Metadata> {
   const channelOrReleaseChannel = await resolveChannelOrReleaseChannelAsync(ctx);
-  const distribution =
-    ('simulator' in ctx.buildProfile && ctx.buildProfile.simulator
-      ? 'simulator'
-      : ctx.buildProfile.distribution) ?? 'store';
+  const distribution = ctx.buildProfile.distribution ?? BuildDistributionType.STORE;
   const metadata: Metadata = {
     trackingContext: ctx.analyticsEventProperties,
     ...(await maybeResolveVersionsAsync(ctx)),
@@ -70,6 +68,7 @@ export async function collectMetadataAsync<T extends Platform>(
     requiredPackageManager: ctx.requiredPackageManager ?? undefined,
     selectedImage: ctx.buildProfile.image,
     customNodeVersion: ctx.buildProfile.node,
+    simulator: 'simulator' in ctx.buildProfile && ctx.buildProfile.simulator,
   };
   return sanitizeMetadata(metadata);
 }

diff --git a/packages/eas-cli/src/build/types.ts b/packages/eas-cli/src/build/types.ts
@@ -11,5 +11,6 @@ export enum BuildStatus {
 export enum BuildDistributionType {
   STORE = 'store',
   INTERNAL = 'internal',
+  /** @deprecated Use simulator flag instead */
   SIMULATOR = 'simulator',
 }
diff --git a/packages/eas-cli/src/commands/build/list.ts b/packages/eas-cli/src/commands/build/list.ts
@@ -10,6 +10,7 @@ import {
   getPaginatedQueryOptions,
 } from '../../commandUtils/pagination';
 import { AppPlatform, BuildStatus as GraphQLBuildStatus } from '../../graphql/generated';
+import Log from '../../log';
 import { RequestedPlatform } from '../../platform';
 import { getDisplayNameForProjectIdAsync } from '../../project/projectUtils';
 import { buildDistributionTypeToGraphQLDistributionType } from '../../utils/buildDistribution';
@@ -51,6 +52,10 @@ export default class BuildList extends EasCommand {
     ...EasPaginatedQueryFlags,
     limit: getLimitFlagWithCustomValues({ defaultTo: 10, limit: BUILDS_LIMIT }),
     ...EasNonInteractiveAndJsonFlags,
+    simulator: Flags.boolean({
+      description:
+        'Filter only iOS simulator builds. Can only be used with --platform flag set to "ios"',
+    }),
   };
 
   static override contextDefinition = {
@@ -69,6 +74,17 @@ export default class BuildList extends EasCommand {
       distribution: buildDistribution,
       'non-interactive': nonInteractive,
     } = flags;
+    if (buildDistribution === BuildDistributionType.SIMULATOR) {
+      Log.warn(
+        `Using --distribution flag with "simulator" value is deprecated - use --simulator flag instead`
+      );
+    }
+    if (flags.simulator && requestedPlatform !== RequestedPlatform.Ios) {
+      Log.error(
+        `The --simulator flag is only usable with --platform flag set to "ios", as it is used to filter specifically iOS simulator builds`
+      );
+      process.exit(1);
+    }
     const {
       privateProjectConfig: { projectId },
       loggedIn: { graphqlClient },
@@ -100,6 +116,7 @@ export default class BuildList extends EasCommand {
         appIdentifier: flags.appIdentifier,
         buildProfile: flags.buildProfile,
         gitCommitHash: flags.gitCommitHash,
+        simulator: flags.simulator,
       },
       paginatedQueryOptions,
     });