Skip to content

Commit

Permalink
Reapply "[eas-cli] popup website in fingerprint:compare (#2859)" (#2862)
Browse files Browse the repository at this point in the history
This reverts commit 528988d.
  • Loading branch information
quinlanj committed Feb 4, 2025
1 parent 365e71f commit c9525e0
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 0 deletions.
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -37,6 +37,7 @@ This is the log of notable changes to EAS CLI and related packages.
- Add update support for fingerprint:compare. ([#2850](https://github.com/expo/eas-cli/pull/2850) by [@quinlanj](https://github.com/quinlanj))
- Add update group id support for fingerprint:compare. ([#2851](https://github.com/expo/eas-cli/pull/2851) by [@quinlanj](https://github.com/quinlanj))
- Add better interactive support for fingerprint:compare. ([#2854](https://github.com/expo/eas-cli/pull/2854) by [@quinlanj](https://github.com/quinlanj))
- Popup website in fingerprint:compare. ([#2859](https://github.com/expo/eas-cli/pull/2859) by [@quinlanj](https://github.com/quinlanj))

## [14.7.1](https://github.com/expo/eas-cli/releases/tag/v14.7.1) - 2025-01-31

Expand Down
14 changes: 14 additions & 0 deletions packages/eas-cli/src/commands/fingerprint/compare.ts
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
import { Platform, Workflow } from '@expo/eas-build-job';
import { Flags } from '@oclif/core';
import openBrowserAsync from 'better-opn';
import chalk from 'chalk';

import { getExpoWebsiteBaseUrl } from '../../api';
Expand Down Expand Up @@ -229,6 +230,19 @@ export default class FingerprintCompare extends EasCommand {
for (const diff of contentDiffs) {
printContentDiff(diff);
}

if (nonInteractive) {
return;
}

const project = await AppQuery.byIdAsync(graphqlClient, projectId);
const fingerprintCompareUrl = new URL(
`/accounts/${project.ownerAccount.name}/projects/${project.name}/fingerprint/compare`,
getExpoWebsiteBaseUrl()
);
fingerprintCompareUrl.searchParams.set('a', firstFingerprintInfo.fingerprint.hash);
fingerprintCompareUrl.searchParams.set('b', secondFingerprintInfo.fingerprint.hash);
await openBrowserAsync(fingerprintCompareUrl.toString());
}
}

Expand Down

0 comments on commit c9525e0

Please sign in to comment.