[eas-cli] skip creation of testflight group when there are already exisitng testflight groups + allow to opt out of the behavior by setting env var #2856
Conversation
…isitng testflight groups + allow to opt out of the behavior by setting env var
This stack of pull requests is managed by Graphite. Learn more about stacking. |
|
❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md. |
|
Subscribed to pull request
Generated by CodeMention |
|
Size Change: +473 B (0%) Total Size: 53.4 MB
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2856 +/- ##
==========================================
- Coverage 52.48% 52.47% -0.01%
==========================================
Files 589 589
Lines 23073 23080 +7
Branches 4823 4825 +2
==========================================
Hits 12108 12108
- Misses 9997 10002 +5
- Partials 968 970 +2 ☔ View full report in Codecov by Sentry. |
| }: { | ||
| groups: BetaGroup[]; | ||
| app: App; | ||
| }): Promise<BetaGroup> { | ||
| let betaGroup = groups.find(group => group.attributes.name === AUTO_GROUP_NAME); | ||
| if (!betaGroup) { |
There was a problem hiding this comment.
This check is now redundant so could be a regular try / catch
| await addAllUsersToInternalGroupAsync(group, admins); | ||
| } | ||
| if (process.env.EXPO_SKIP_TESTFLIGHT_SETUP) { | ||
| Log.debug('EXPO_SKIP_TESTFLIGHT_SETUP is set, skipping TestFlight setup'); |
There was a problem hiding this comment.
In Expo CLI we usually format like EXPO_NO_.
Why
https://exponent-internal.slack.com/archives/C014YHUJUMN/p1738577486565949?thread_ts=1738574914.864689&cid=C014YHUJUMN
How
If there are any existing testflight groups skip the creation of the
Team (Expo)group.Allow to opt out of the creation y setting
EXPO_SKIP_TESTFLIGHT_SETUP=1Test Plan
Tests