Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] print no vcs warning only once #2863

Merged
merged 2 commits into from
Feb 4, 2025

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 4, 2025

Why

https://exponent-internal.slack.com/archives/C017N0N99RA/p1738630158821649

How

Print warn message only once

Test Plan

Tests

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review February 4, 2025 08:59
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

✅ Thank you for adding the changelog entry!

@szdziedzic szdziedzic merged commit 0513fc5 into main Feb 4, 2025
7 checks passed
@szdziedzic szdziedzic deleted the 02-04-_eas-cli_print_no_vcs_warning_only_once branch February 4, 2025 09:02
Copy link

github-actions bot commented Feb 4, 2025

Size Change: +2.05 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.05 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 25.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 52.40%. Comparing base (528988d) to head (1be2847).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/index.ts 25.00% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2863      +/-   ##
==========================================
- Coverage   52.41%   52.40%   -0.00%     
==========================================
  Files         589      589              
  Lines       23110    23113       +3     
  Branches     4838     4839       +1     
==========================================
+ Hits        12110    12111       +1     
- Misses      10034    10035       +1     
- Partials      966      967       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants