Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] cache downloaded app archives in eas build:dev #2864

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 4, 2025

Why

We don't need to redownload app every single time in eas build:dev. We can cache it locally. This functionality already exists for eas build:run.

How

Use caching the same way we do for eas build:run

Test Plan

Tested manually

Copy link

github-actions bot commented Feb 4, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review February 4, 2025 11:01
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

Size Change: -3.97 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -3.97 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 44.44444% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.36%. Comparing base (077d8b3) to head (0f644aa).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/build/runBuildAndSubmit.ts 33.34% 5 Missing and 1 partial ⚠️
packages/eas-cli/src/run/run.ts 50.00% 3 Missing ⚠️
packages/eas-cli/src/commands/build/dev.ts 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2864      +/-   ##
==========================================
- Coverage   52.37%   52.36%   -0.00%     
==========================================
  Files         588      588              
  Lines       23114    23119       +5     
  Branches     4842     4843       +1     
==========================================
+ Hits        12103    12104       +1     
- Misses      10039    10042       +3     
- Partials      972      973       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit 5c6880f into main Feb 4, 2025
11 of 12 checks passed
@szdziedzic szdziedzic deleted the 02-04-_eas-cli_cache_downloaded_app_archives_in_eas_build_dev branch February 4, 2025 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants