Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] log time that it took to complete the previous build in eas build:dev #2865

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 4, 2025

Why

@brentvatne suggested that it would be useful to let people know how long the previous build took when rebuilding in eas build:dev

How

Get the information about how long previous build took and show it to the user

Test Plan

Tested manually

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

@szdziedzic szdziedzic marked this pull request as ready for review February 4, 2025 11:20
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

Size Change: +1.91 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +1.91 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 9.09091% with 10 lines in your changes missing coverage. Please review.

Project coverage is 52.35%. Comparing base (077d8b3) to head (fe61155).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/build/dev.ts 9.10% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2865      +/-   ##
==========================================
- Coverage   52.37%   52.35%   -0.01%     
==========================================
  Files         588      588              
  Lines       23114    23121       +7     
  Branches     4842     4845       +3     
==========================================
  Hits        12103    12103              
- Misses      10039    10045       +6     
- Partials      972      973       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic added the no changelog PR that doesn't require a changelog entry label Feb 4, 2025 — with Graphite App
@szdziedzic szdziedzic merged commit d5f562e into main Feb 4, 2025
12 of 13 checks passed
@szdziedzic szdziedzic deleted the 02-04-_eas-cli_log_time_that_it_took_to_complete_the_previous_build_in_eas_build_dev branch February 4, 2025 11:34
Copy link

github-actions bot commented Feb 4, 2025

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants