Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] auto start dev client server at the end of eas build:dev #2868

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 4, 2025

Why

Auto-start dev client server at the end of eas build:dev command

How

Auto-start dev client server at the end of eas build:dev command

Test Plan

Tested manually

Screen Recording 2025-02-04 at 13.00.38.mov (uploaded via Graphite)

Copy link
Member Author

This stack of pull requests is managed by Graphite. Learn more about stacking.

Copy link

github-actions bot commented Feb 4, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

@szdziedzic szdziedzic marked this pull request as ready for review February 4, 2025 12:07
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

Size Change: -1.89 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -1.89 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.

Project coverage is 52.33%. Comparing base (8a2d68f) to head (e8fd073).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/commands/build/dev.ts 20.00% 8 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2868      +/-   ##
==========================================
- Coverage   52.34%   52.33%   -0.01%     
==========================================
  Files         588      588              
  Lines       23126    23136      +10     
  Branches     4846     4848       +2     
==========================================
+ Hits        12104    12106       +2     
- Misses      10048    10056       +8     
  Partials      974      974              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic merged commit 85a6662 into main Feb 4, 2025
11 of 12 checks passed
@szdziedzic szdziedzic deleted the 02-04-_eas-cli_auto_start_dev_client_server_at_the_end_of_eas_build_dev branch February 4, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants