Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "[eas-cli] Use Git to pack Git projects" #2870

Conversation

szdziedzic
Copy link
Member

@szdziedzic szdziedzic commented Feb 4, 2025

It seems like #2841 caused some undesired side effects #2866

This PR should revert this change

@szdziedzic szdziedzic requested a review from sjchmiela February 4, 2025 14:24
Copy link

linear bot commented Feb 4, 2025

Copy link

linear bot commented Feb 4, 2025

Copy link

github-actions bot commented Feb 4, 2025

❌ It looks like a changelog entry is missing for this PR. Add it manually to CHANGELOG.md.
⏩ If this PR doesn't require a changelog entry, such as if it's an internal change that doesn't affect the user experience, you can add the "no changelog" label to the PR.

Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

@szdziedzic szdziedzic requested a review from kadikraman February 4, 2025 14:25
Copy link

github-actions bot commented Feb 4, 2025

Size Change: -4.87 kB (-0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -4.87 kB (-0.01%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 23.63636% with 42 lines in your changes missing coverage. Please review.

Project coverage is 52.37%. Comparing base (be9fb59) to head (bf1c404).
Report is 15 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/clients/git.ts 0.00% 16 Missing and 2 partials ⚠️
packages/eas-cli/src/vcs/clients/gitNoCommit.ts 28.00% 18 Missing ⚠️
packages/eas-cli/src/vcs/index.ts 25.00% 2 Missing and 1 partial ⚠️
packages/eas-cli/src/commands/build/internal.ts 66.67% 1 Missing ⚠️
...ackages/eas-cli/src/commands/project/onboarding.ts 0.00% 1 Missing ⚠️
packages/eas-cli/src/commands/submit/internal.ts 66.67% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2870      +/-   ##
==========================================
+ Coverage   52.33%   52.37%   +0.04%     
==========================================
  Files         588      589       +1     
  Lines       23136    23135       -1     
  Branches     4848     4845       -3     
==========================================
+ Hits        12106    12114       +8     
+ Misses      10056    10052       -4     
+ Partials      974      969       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@szdziedzic szdziedzic closed this Feb 6, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants