Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] reapply website launcher #2871

Merged
merged 2 commits into from
Feb 4, 2025
Merged

[eas-cli] reapply website launcher #2871

merged 2 commits into from
Feb 4, 2025

Conversation

quinlanj
Copy link
Member

@quinlanj quinlanj commented Feb 4, 2025

Why

Reapply #2859

Copy link

github-actions bot commented Feb 4, 2025

✅ Thank you for adding the changelog entry!

@quinlanj quinlanj merged commit d9af6cb into main Feb 4, 2025
6 checks passed
@quinlanj quinlanj deleted the @quin/reapply-launcher branch February 4, 2025 19:37
Copy link

github-actions bot commented Feb 4, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @sjchmiela, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 4, 2025

Size Change: +2.89 kB (+0.01%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +2.89 kB (+0.01%)

compressed-size-action

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 12.50000% with 7 lines in your changes missing coverage. Please review.

Project coverage is 52.32%. Comparing base (365e71f) to head (64ced53).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ckages/eas-cli/src/commands/fingerprint/compare.ts 12.50% 6 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2871      +/-   ##
==========================================
- Coverage   52.33%   52.32%   -0.01%     
==========================================
  Files         588      588              
  Lines       23137    23145       +8     
  Branches     4848     4849       +1     
==========================================
+ Hits        12107    12108       +1     
- Misses      10056    10062       +6     
- Partials      974      975       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant