Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Fix deleting ignored submodules when archiving project #2884

Merged
merged 3 commits into from
Feb 6, 2025

Conversation

sjchmiela
Copy link
Contributor

@sjchmiela sjchmiela commented Feb 5, 2025

Why

git ls-files returns submodules as a single filepath entry, so rm must remove it with -rf. Fixes #2883.

How

Added { recursive: true, force: true } to fs.rm.

Test Plan

I tried easd build:inspect -p android -s archive -o ~/testtest --force on a repo with a submodule in .easignore. It succeeded and the submodule was not included in the folder.

Copy link

github-actions bot commented Feb 5, 2025

Size Change: +604 B (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB +604 B (0%)

compressed-size-action

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 52.61%. Comparing base (b3d0924) to head (767e696).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2884      +/-   ##
==========================================
+ Coverage   52.41%   52.61%   +0.21%     
==========================================
  Files         588      588              
  Lines       23169    23169              
  Branches     4851     4851              
==========================================
+ Hits        12142    12189      +47     
+ Misses      10053    10014      -39     
+ Partials      974      966       -8     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sjchmiela sjchmiela marked this pull request as ready for review February 5, 2025 20:21
Copy link

github-actions bot commented Feb 5, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

@benjaminkomen
Copy link

I'm not sure if it would be easy to add a test to prevent regression of this scenario? Maybe a future task.

@sjchmiela sjchmiela requested a review from szdziedzic February 5, 2025 20:28
Copy link

github-actions bot commented Feb 5, 2025

✅ Thank you for adding the changelog entry!

@sjchmiela sjchmiela merged commit 035ca03 into main Feb 6, 2025
10 checks passed
@sjchmiela sjchmiela deleted the stanley/fix-submodules branch February 6, 2025 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

V15 breaks EAS build (Path is a directory: rm returned EISDIR (is a directory))
3 participants