Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eas-cli] Allow normalizing root path to fix Windows not ignoring files #2892

Merged
merged 2 commits into from
Feb 9, 2025

Conversation

sjchmiela
Copy link
Contributor

Why

Since v15 files that should be ignored get added to the tarball on Windows.

How

After adding some debugging I was able to find that src, srcFilePath don't match on path separators which breaks ignore.ignores.

Zrzut ekranu 2025-02-7 o 21 57 02

Added path.normalize if __NORMALIZE is 1.


Also noticed we used wrong cwd for is-tracked check.

Test Plan

Going to release this and test.

@sjchmiela sjchmiela requested a review from szdziedzic February 7, 2025 20:58
Copy link

github-actions bot commented Feb 7, 2025

Subscribed to pull request

File Patterns Mentions
**/* @szdziedzic, @khamilowicz, @radoslawkrzemien

Generated by CodeMention

Copy link

github-actions bot commented Feb 7, 2025

Size Change: -2.58 kB (0%)

Total Size: 53.4 MB

Filename Size Change
./packages/eas-cli/dist/eas-linux-x64.tar.gz 53.4 MB -2.58 kB (0%)

compressed-size-action

Copy link

codecov bot commented Feb 7, 2025

Codecov Report

Attention: Patch coverage is 83.33333% with 1 line in your changes missing coverage. Please review.

Project coverage is 52.64%. Comparing base (f334bdb) to head (b9cd958).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
packages/eas-cli/src/vcs/local.ts 75.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2892      +/-   ##
==========================================
+ Coverage   52.63%   52.64%   +0.01%     
==========================================
  Files         588      588              
  Lines       23183    23187       +4     
  Branches     4854     4856       +2     
==========================================
+ Hits        12201    12204       +3     
- Misses      10016    10017       +1     
  Partials      966      966              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brentvatne
Copy link
Member

is the __NORMALIZE env var something special on windows or is this something you're exposing to test the change?

@sjchmiela
Copy link
Contributor Author

Something I'm exposing to test the change

@sjchmiela sjchmiela added the no changelog PR that doesn't require a changelog entry label Feb 8, 2025
Copy link

github-actions bot commented Feb 8, 2025

⏩ The changelog entry check has been skipped since the "no changelog" label is present.

@sjchmiela sjchmiela changed the title [eas-cli] Normalize root path to fix Windows not ignoring files [eas-cli] Allow normalizing root path to fix Windows not ignoring files Feb 9, 2025
@sjchmiela sjchmiela merged commit b86696f into main Feb 9, 2025
10 of 11 checks passed
@sjchmiela sjchmiela deleted the stanley/normalize-path-windows branch February 9, 2025 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no changelog PR that doesn't require a changelog entry
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants