-
Notifications
You must be signed in to change notification settings - Fork 92
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[eas-cli] Do not include files deleted in working directory #2900
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Size Change: +1.5 kB (0%) Total Size: 53.4 MB
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #2900 +/- ##
==========================================
+ Coverage 52.64% 52.67% +0.03%
==========================================
Files 588 588
Lines 23186 23188 +2
Branches 4854 4856 +2
==========================================
+ Hits 12204 12211 +7
+ Misses 10016 10011 -5
Partials 966 966 ☔ View full report in Codecov by Sentry. |
Subscribed to pull request
Generated by CodeMention |
szdziedzic
approved these changes
Feb 11, 2025
0737fda
to
fb2b1dc
Compare
✅ Thank you for adding the changelog entry! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
When we
git clone
the source repository and then copy worktree changes over, we add and modify files. However, we do not delete files that have been deleted in worktree.How
When we operate in
requireCommit: false
mode, we add--no-checkout
to thegit clone
command. This way the destination directory only has.git
directory when we start copying files over. Thus, files deleted from worktree will not suddenly appear in tarball.In
requireCommit: true
mode we don't add--no-checkout
, because we don't copy files.Test Plan
Added test. Tested manually.
Side effect of this is that
git status
reports that all files have been deleted and there's a bunch of untracked files (which,git add
-ed, make the repository appear as the source repo). I don't know how to copy the Git index 1-1…