fix: re-enable no-control-regex#3
Merged
Merged
Conversation
Member
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Apr 9, 2026
tchayen
approved these changes
Apr 9, 2026
Member
Author
Merge activity
|
wschurman
changed the base branch from
wschurman/04-09-chore_explicitly_enable_some_rules_that_are_on_by_default
to
graphite-base/3
wschurman
force-pushed
the
wschurman/04-09-fix_re-enable_no-control-regex
branch
from
2e9b3fa to
0fc8e7f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It wasn't immediately obvious to me why we'd have this off by default since oxlint enables it by default: https://oxc.rs/docs/guide/usage/linter/rules/eslint/no-control-regex.html
It does appear that there is code in expo/expo that disables the eslint rule explicitly: https://github.com/search?q=repo%3Aexpo%2Fexpo%20no-control-regex&type=code. I think this order of precedence is correct. On by default to match oxlint default, explicit per-case disable.