Fix frame capture callback lifetime#12
Draft
sjchmiela wants to merge 3 commits into
Draft
Conversation
32c5cf5 to
64ebdfd
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
A local
npx @expo/serve-simcrash report showedSIGBUSon theframe-capturequeue inserve-sim-native.node, symbolicated throughFrameCapture.captureFrame()andFrameCapture.registerFrameCallbacks(desc:). The callback blocks were local Swift values passed throughobjc_msgSend; this keeps explicit strong references to them while SimulatorKit callbacks are registered.Validation
npm exec --yes --package bun@latest -- bun run packages/serve-sim/build.ts./node_modules/.bin/tsc --noEmitI did not live-test against a booted simulator because none were booted when validating this change.