chore: remove fetch ponyfill #649
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
I was running into the following error when using the Snack SDK in CF Workers.
I've tracked down the issue to an old
node-fetch.How
This PR removes the current ponyfill and defaults to global fetch impl of the runtime.
Since all modern browser have a solid
fetchimplementation, I think we could use the global for web. Likely we could do the same for Expo Apps.For modern node ponyfill would also not be needed. But for other envs for example CF Workers, we need the ability to change the
fetchfunction. So I exposed a public functionsetSnackSDKFetch(fn).Test Plan