Skip to content

ci: add Go 1.23/1.24 testing and fix example test names #760

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 2, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-versions: [ '1.18', '1.22' ]
go-versions: [ '1.18', '1.22', '1.24' ]
go-arch: [ '386' ]
steps:
- uses: actions/checkout@v3
Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
go-versions: [ '1.18', '1.19', '1.20', '1.21', '1.22' ]
go-versions: [ '1.18', '1.19', '1.20', '1.21', '1.22', '1.23', '1.24' ]
steps:
- uses: actions/checkout@v3
- name: Setup Go ${{ matrix.go-version }}
Expand Down
4 changes: 2 additions & 2 deletions expr_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -312,7 +312,7 @@ func ExampleOperator() {
// Output: true
}

func ExampleOperator_Decimal() {
func ExampleOperator_with_decimal() {
type Decimal struct{ N float64 }
code := `A + B - C`

Expand Down Expand Up @@ -585,7 +585,7 @@ func ExampleWithContext() {
// Output: 42
}

func ExampleWithTimezone() {
func ExampleTimezone() {
program, err := expr.Compile(`now().Location().String()`, expr.Timezone("Asia/Kamchatka"))
if err != nil {
fmt.Printf("%v", err)
Expand Down
6 changes: 3 additions & 3 deletions internal/difflib/difflib_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -102,7 +102,7 @@ group
}
}

func ExampleGetUnifiedDiffCode() {
func ExampleGetUnifiedDiffString() {
a := `one
two
three
Expand Down Expand Up @@ -135,7 +135,7 @@ four`
// -fmt.Printf("%s,%T",a,b)
}

func ExampleGetContextDiffCode() {
func ExampleGetContextDiffString() {
a := `one
two
three
Expand Down Expand Up @@ -172,7 +172,7 @@ four`
// four
}

func ExampleGetContextDiffString() {
func ExampleGetContextDiffString_second() {
a := `one
two
three
Expand Down
Loading