ci: pin benchstat version and update GitHub Actions #761
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
thevilledev
force-pushed
the
fix/ci
branch
2 times, most recently
from
79cf213 to
8a3c266
Compare
thevilledev
changed the title
Fix CI workflow compatibility issues and update dependencies: - Pin benchstat to specific commit (884df5) compatible with Go 1.18 instead of using @latest which now requires Go 1.23+ - Add explanatory comment about benchstat version constraints - Upgrade actions/upload-artifact from v3 to v4 in fuzz.yml - Upgrade github/codeql-action from v2 to v3 in fuzz.yml These changes ensure the CI pipeline remains compatible with Go 1.18 while benefiting from the latest improvements in GitHub Actions. Signed-off-by: Ville Vesilehto <[email protected]>
antonmedv
approved these changes
Mar 1, 2025
SimFG
pushed a commit
to SimFG/expr
that referenced
this pull request
Apr 15, 2025
Fix CI workflow compatibility issues and update dependencies: - Pin benchstat to specific commit (884df5) compatible with Go 1.18 instead of using @latest which now requires Go 1.23+ - Add explanatory comment about benchstat version constraints - Upgrade actions/upload-artifact from v3 to v4 in fuzz.yml - Upgrade github/codeql-action from v2 to v3 in fuzz.yml These changes ensure the CI pipeline remains compatible with Go 1.18 while benefiting from the latest improvements in GitHub Actions. Signed-off-by: Ville Vesilehto <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At the moment CI runs fail due to:
This PR fixes CI workflow compatibility issues and updates dependencies:
instead of using "latest" which now requires Go 1.23+
These changes ensure the CI pipeline remains compatible with Go 1.18
while benefiting from the latest improvements in GitHub Actions.
Hopefully fixes CI issues for #760