Add post-parsing verify function #472
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Allow user to specify a function to run on the parsed output. This
function gets the req and res as does the normal parsing middlewares but
operates on the parsed data.
This patch is only a sketch to illustrate my idea, I haven't implemented
tests or anything, but wanted to see if such a feature is of interest to
the project.
My specific usecase is that i want to use bodyparser with json-schema.
I wanted to use the verify function option, but in order to do that I
would need to reparse the json. I could also wrap the bodyparser
middleware in my own middleware, but this is more complicated than
adding for example "verifyParsed: (rq,rs,b) => {validate(b)}" to the
bodyparser middleware.
|
Hey @jhford-scout24, sorry for the very much delayed response. The express project has struggled with investment for some years now but we are trying to get back on track. I just wanted to drop a note in here though to see if you were still interested in having this conversation. I have some thoughts, but we need to ruthlessly prioritize the required work to get the next majro released, and it is highly unlikely we would land this PR for that. That said, I think I am interested in thinking about this problem space a bit more clearly, and I am interested in |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow user to specify a function to run on the parsed output. This function gets the req and res as does the normal parsing middlewares but operates on the parsed data.
This patch is only a sketch to illustrate my idea, I haven't implemented tests or anything, but wanted to see if such a feature is of interest to the project. I would also add this functionality to the other parsed body types if the patch is acceptable.
My specific use case is that i want to use bodyparser with json-schema. I wanted to use the verify function option, but in order to do that I would need to reparse the json. I could also wrap the bodyparser middleware in my own middleware, but this is more complicated than adding for example
verifyParsed: (rq,rs,b) => {validate(b)}to the bodyparser middleware.