Skip to content

chore: add .editorconfig #601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Phillip9587
Copy link
Contributor

@Phillip9587 Phillip9587 commented Mar 31, 2025

This pull request adds a .editorconfig file. The config is copied from nodejs/node.

Docs: https://editorconfig.org/

Related: expressjs/discussions#327

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really don't want more configuration files, I don't see any benefit in it.

I know it's also in the Express repository, but I honestly don't see any benefit and would even remove it from there as well.

@Phillip9587
Copy link
Contributor Author

Since we don’t currently have a linter or formatter in place across the repos, and especially in this one, which I’ve been working with extensively, I’d like to suggest adding an .editorconfig file.

This would help standardize code formatting across different editors and ensure consistent practices for things like indentation, line endings, and spacing. It can also help reduce unnecessary merge conflicts and make collaboration smoother overall.

With an .editorconfig file, contributors automatically follow a consistent style, regardless of the editor or IDE they use. It’s a small addition that can make a big difference.

@bjohansebas
Copy link
Member

We have a linter, which is Standard, and it also applies certain formatting. The previous maintainer implemented it in most, if not all, repositories.

We want to standardize a new linter because Standard no longer works well with the latest version of ESLint, and it doesn't seem like the Standard project will continue. That's why we're discussing the linter, but in reality, we already have a linter that needs to be updated because Standard won't be updated anymore.

@Phillip9587
Copy link
Contributor Author

@bjohansebas Maybe we can discuss in expressjs/discussions#327

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants