Generic Parser #606
Draft
Generic Parser #606
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonchurch
commented
Apr 8, 2025
| */ | ||
|
|
||
| function generic (options) { | ||
| // === STEP 0: VALIDATE OPTIONS === |
There was a problem hiding this comment.
Breaking this function down into steps was very helpful for me when wrapping my head around what was a universal concern vs parser specfic. leaving them here hoping they help others
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An attempt at solving for #22 (specifically #22 (comment)) and sketching out what the generic interaface would look like.
This is a draft so we can see the diff cleanly, but it's my intent for Generic ot be hashed out on the
genericbranch.This is an approach which encapsulates Generic as the only middleware to have a
parseroption.Users of generic would be required to bring a
typeand a syncparsefunction