Implemented req.completeUrl #4958
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Johan511
changed the title
| @@ -449,11 +449,15 @@ defineGetter(req, 'hostname', function hostname(){ | |||
| : host; | |||
| }); | |||
|
|
|||
| // TODO: change req.host to return host in next major | |||
| defineGetter(req, 'completeUrl', function completeUrl(){ | |||
| return req.protocol + '://' + req.get('host') + req.originalUrl; | |||
There was a problem hiding this comment.
Hi @Johan511, i'm just thinking about a crud api set, the completeUrl function probably need to manage some parameters or subroute,
examples:
- http://myhost/user/1
- http://myhost/user/1/detail
- http://myhost/user/1/detail/summary
so the question is, is this method really usable? or the purpose is just to have one base url?
Can you please implements some tests to really understand the functionality?
dougwilson
force-pushed
the
master
branch
2 times, most recently
from
eb10dba to
340be0f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added new getter completeUrl to req object as discussed in #4697