Skip to content

Feat:- Add GitHub edit btn #1822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 14 commits into from
Mar 15, 2025
Merged

Feat:- Add GitHub edit btn #1822

merged 14 commits into from
Mar 15, 2025

Conversation

ShubhamOulkar
Copy link
Member

@ShubhamOulkar ShubhamOulkar commented Feb 27, 2025 •
edited
Loading

Button is added on following pages

  • pages layout
  • api layouts

Design

light mode dark mode
image image

Closes #1759

@ShubhamOulkar ShubhamOulkar requested review from a team as code owners February 27, 2025 05:21
@netlify Netlify
Copy link

netlify bot commented Feb 27, 2025 •
edited
Loading

✅ Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit a91dbe4
🔍 Latest deploy log https://app.netlify.com/sites/expressjscom-preview/deploys/67d5ded2fd4e240008a4c2be
😎 Deploy Preview https://deploy-preview-1822--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@ShubhamOulkar ShubhamOulkar marked this pull request as draft February 27, 2025 05:24
@ShubhamOulkar ShubhamOulkar marked this pull request as ready for review February 27, 2025 05:42
@ShubhamOulkar ShubhamOulkar changed the title (WIP) Feat:- Add GitHub edit btn Feat:- Add GitHub edit btn Mar 2, 2025
@carlosstenzel
Copy link
Contributor

I like the idea, but I think the button should have a highlight and not only on :hover.

@ShubhamOulkar
Copy link
Member Author

@carlosstenzel , I am thinking about adding edit btn icon on api page for each section and sub section headers. What do you think?

@bjohansebas
Copy link
Member

I am thinking about adding edit btn icon on api page for each section and sub section headers. What do you think?

I don't think it's a good idea, we would have too many buttons for the API. I think it would make more sense for the link to lead to a folder where the API files are in GitHub.

bjohansebas
bjohansebas reviewed Mar 10, 2025
View reviewed changes
@bjohansebas bjohansebas self-assigned this Mar 15, 2025
bjohansebas
bjohansebas approved these changes Mar 15, 2025
View reviewed changes
Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for working on this!

@bjohansebas bjohansebas merged commit 26d0b1f into expressjs:gh-pages Mar 15, 2025
7 checks passed
@ShubhamOulkar ShubhamOulkar deleted the github-edit-btn branch March 16, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bjohansebas bjohansebas bjohansebas approved these changes

Assignees

@bjohansebas bjohansebas

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Show a button to edit the content
3 participants
@ShubhamOulkar @carlosstenzel @bjohansebas