Skip to content

Update menu.md #1907

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Update menu.md #1907

wants to merge 1 commit into from

Conversation

0xadri
Copy link

@0xadri 0xadri commented May 19, 2025

Add link for res and req objects

@0xadri 0xadri requested review from a team as code owners May 19, 2025 10:49
Copy link

netlify bot commented May 19, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit d8d6578
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/682b0ca6708e690008b83b1a
😎 Deploy Preview https://deploy-preview-1907--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

Copy link
Member

@ShubhamOulkar ShubhamOulkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @0xadri, don't need to add additional links. See line no 71 and 139. Anchor links are correctly linked to respective ID's.

Default links behavior is disabled in menu.js file to stop instantaneous scroll on the page. On click, a submenu opens as well as the page is scrolling instantaneously.

Are you in favor of removing line 187? Or implementing smooth scroll on click.

@ShubhamOulkar
Copy link
Member

Are you in favor of removing line 187? Or implementing smooth scroll on click.

Hi @0xadri, are you interested in doing changes as above?

@0xadri
Copy link
Author

0xadri commented May 29, 2025

Hi @ShubhamOulkar

don't need to add additional links. See line no 71 and 139. Anchor links are correctly linked to respective ID's.

Oh I see now, there is a nested level ul-li elements and indeed anchor links to the respective ID's.

Default links behavior is disabled in menu.js file to stop instantaneous scroll on the page

Yes for the top level of ul-li's.

On click, a submenu opens as well as the page is scrolling instantaneously.

For me when I click on "request" or "response" top level menu items, I only get the submenu opening. The page does not scroll. I'm on Firefox 138.0.4 (64-bit) for MacOS.

Are you in favor of removing line 187? Or implementing smooth scroll on click.

No biggy. I don't mind the solution you chose. Just tried to help really :]

@ShubhamOulkar
Copy link
Member

ShubhamOulkar commented May 30, 2025

I'm proposing a new feature to implement smooth scrolling for better user experience. Please continue the discussion and share ideas here #1932.

Closing this PR since the requested changes to the links are unrelated to the main goal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants