Skip to content

Normalize i18n notice translation #1930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 1, 2025

Conversation

ShubhamOulkar
Copy link
Member

@ShubhamOulkar ShubhamOulkar commented May 28, 2025

closes #1768

related pr #1779

Right now it shows an empty notice box, but the notice will populate once translation is updated by Crowdin.

@ShubhamOulkar ShubhamOulkar requested review from a team as code owners May 28, 2025 12:30
Copy link

netlify bot commented May 28, 2025

Deploy Preview for expressjscom-preview ready!

Name Link
🔨 Latest commit cd1fba0
🔍 Latest deploy log https://app.netlify.com/projects/expressjscom-preview/deploys/6837438687ad0c0008a0ec53
😎 Deploy Preview https://deploy-preview-1930--expressjscom-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@bjohansebas
Copy link
Member

I think we need to do this step manually for now, since it would be unusual for the alert to appear without text or we could probably implement some logic to check if the string exists, and if not, fall back to the English one

@ShubhamOulkar
Copy link
Member Author

fall back to the English one

added in 1b42b97

@ShubhamOulkar ShubhamOulkar requested a review from bjohansebas May 28, 2025 14:37
@bjohansebas
Copy link
Member

I guess we won’t be able to use some Liquid/Jekyll methods, maybe we’ll have to put the text directly and upload the file to Crowdin.

imagen

@ShubhamOulkar
Copy link
Member Author

maybe we’ll have to put the text directly and upload the file to Crowdin.

  <a href="{{ page.url | replace: '/en/', '/en/' }}">documentation in English</a>.

That was the doubt I forgot to include in the description. Maybe doing it manually in Crowdin is the only option.

@bjohansebas
Copy link
Member

That was the doubt I forgot to include in the description. Maybe doing it manually in Crowdin is the only option.

We can’t, because the link is dynamic.

@bjohansebas
Copy link
Member

Although we can probably remove the banner, right? @expressjs/docs-wg WDYT?

@ShubhamOulkar
Copy link
Member Author

ShubhamOulkar commented May 28, 2025

imagen

The issue is fixed in cd1fba0.

Copy link
Member

@bjohansebas bjohansebas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, let's leave this open a bit longer.

@bjohansebas bjohansebas merged commit 124133a into expressjs:gh-pages Jun 1, 2025
9 checks passed
@bjohansebas
Copy link
Member

thanks @ShubhamOulkar!

@ShubhamOulkar ShubhamOulkar deleted the i18n-alert branch June 1, 2025 03:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Separate the content of the layout
2 participants