-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Normalize i18n notice translation #1930
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for expressjscom-preview ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
I think we need to do this step manually for now, since it would be unusual for the alert to appear without text or we could probably implement some logic to check if the string exists, and if not, fall back to the English one |
added in 1b42b97 |
That was the doubt I forgot to include in the description. Maybe doing it manually in Crowdin is the only option. |
We can’t, because the link is dynamic. |
Although we can probably remove the banner, right? @expressjs/docs-wg WDYT? |
The issue is fixed in cd1fba0. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, let's leave this open a bit longer.
thanks @ShubhamOulkar! |
closes #1768
related pr #1779
Right now it shows an empty notice box, but the notice will populate once translation is updated by Crowdin.