-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
fix: handle two busboy error events #1296
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: lts
Are you sure you want to change the base?
Conversation
@UlisesGascon @LinusU Please take a look, when you have a chance. Thanks. |
Could you duplicate the test into a new one, instead of modifying the current one, so that we are sure that the previous single error is also handled? 🙏 |
b3d69ae
to
8f6279b
Compare
@LinusU Done, please take a look. |
@UlisesGascon @LinusU Please take a look, when you have a chance. Thanks. |
Not sure why the CI pipeline was not triggered 🤔 |
@UlisesGascon see #1302 |
@UlisesGascon @LinusU Are the CI failures blockers to this PR? The tests are passing on supported Node.js versions. |
this looks good, but we are pulling in this fix as part of another PR. I will update when that gets merged. thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
waiting to merge, please hold
This PR enables
multer
to handle two out-of-band error events frombusboy
; it does this by replacingprocess.nextTick
(which happens too soon after the first error event) withsetImmediate
.I don't know if this fix will handle more than two, but I also don't think
busboy
will ever emit more than two.This is a follow-up to #1177.
Resolves #1176.