Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With huge session object the hash method become slower because iterate on each key/value of the object, just for remove the cookie property on the first level!
This PR make hash method 2/3x faster!
Online benchmark
This PR use the spread operator available on Node.js >= 8.3
if we need to support old NodeJS, I can introduce a new options for cusom hash function, eg:
In this case, close this PR and merge this one #1035
Side note: this new options, also can close #990