Skip to content

refactor : replace deprecated substr() with slice() #1099

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Ayoub-Mabrouk wants to merge 1 commit into
base: master
Choose a base branch
from
Open

refactor : replace deprecated substr() with slice() #1099

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -546,7 +546,7 @@ function getcookie(req, name, secrets) {
raw = cookies[name];

if (raw) {
if (raw.substr(0, 2) === 's:') {
if (raw.slice(0, 2) === 's:') {
val = unsigncookie(raw.slice(2), secrets);

if (val === false) {
Expand All @@ -573,7 +573,7 @@ function getcookie(req, name, secrets) {
raw = req.cookies[name];

if (raw) {
if (raw.substr(0, 2) === 's:') {
if (raw.slice(0, 2) === 's:') {
val = unsigncookie(raw.slice(2), secrets);

if (val) {
Expand Down Expand Up @@ -648,7 +648,7 @@ function issecure(req, trustProxy) {
var header = req.headers['x-forwarded-proto'] || '';
var index = header.indexOf(',');
var proto = index !== -1
? header.substr(0, index).toLowerCase().trim()
? header.slice(0, index).toLowerCase().trim()
: header.toLowerCase().trim()

return proto === 'https';
Expand Down
2 changes: 1 addition & 1 deletion test/session.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1019,9 +1019,9 @@
var store = new session.MemoryStore()
var server = createServer({ resave: false, store: store }, function (req, res) {
if (req.method === 'PUT') {
req.session.token = req.url.substr(1)
req.session.token = req.url.slice(1)
}
res.end('token=' + (req.session.token || ''))

Check failure

Code scanning / CodeQL

Reflected cross-site scripting High test

Cross-site scripting vulnerability due to a
user-provided value
Loading
.
})

request(server)
Expand Down