Skip to content

Fix session cookie refresh when cookie options are mutated#1121

Open
raashish1601 wants to merge 1 commit into
expressjs:masterfrom
raashish1601:codex/1002-set-cookie-is-not-being-passed-in-header-when-session-is
Open

Fix session cookie refresh when cookie options are mutated#1121
raashish1601 wants to merge 1 commit into
expressjs:masterfrom
raashish1601:codex/1002-set-cookie-is-not-being-passed-in-header-when-session-is

Conversation

@raashish1601
Copy link
Copy Markdown

Summary

  • Track explicit session cookie mutations so cookie-only updates can emit Set-Cookie for existing sessions.
  • Preserve the clean cookie state when sessions are created or loaded from the store, so unmodified sessions keep the existing non-rolling behavior.
  • Add regression coverage for req.session.cookie.maxAge changes followed by touch() and save().

Fixes #1002.

Validation

  • npx eslint index.js session/cookie.js session/session.js session/store.js test/session.js
  • bash -lc "tr -d '\r' < test/support/gencert.sh | bash"
  • npx mocha --require test/support/env --check-leaks --no-exit --reporter spec test/session.js (143 passing)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Set cookie is not being passed in header when session is extended, due to which browser cookie is never extended

1 participant