Skip to content

Prevent the rolling: true option from overriding the saveUnitialized: false option #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed

Conversation

JamesMGreene
Copy link
Contributor

Prevent the rolling: true option from overriding the saveUnitialized: false option.

Fixes #239.

@JamesMGreene
Copy link
Contributor Author

@dougwilson: I'm sure you're day-job-and-open-source-swamped like the rest of us but if there is any chance of getting this PR and PR #242 merged and released within the next 2 weeks or so, my team and I would appreciate it! 👍 💝

@dougwilson
Copy link
Contributor

Hi James, I got the emails from your issues and pull requests :) Nothing was obviously wrong on this pull request, but I just haven't gotten to an actual computer just yet, only been doing what I can from my phone. I was planning on merging this weekend unless when I sat down to look at the diff there was a glaring issue (I can fix any minor issues without waiting on you). Hopefully it should be smooth.

@dougwilson dougwilson self-assigned this Dec 12, 2015
@dougwilson dougwilson added the bug label Dec 12, 2015
@JamesMGreene
Copy link
Contributor Author

Sounds good, @dougwilson. Thanks! 👍

I'll keep an eye out for any feedback requiring changes on my part. 👀

@dougwilson
Copy link
Contributor

Hi @JamesMGreene , I'm sorry, I had another user just eat up all my time tonight, so I wasn't able to get to your pull requests yet. I may not have any further time over this weekend, but will see what I can do. Sorry for the delay!

@JamesMGreene
Copy link
Contributor Author

No worries, @dougwilson... I understand all too well the wonderful time burden of open source. 💝

@dougwilson
Copy link
Contributor

No problem :) Looking now.

@JamesMGreene
Copy link
Contributor Author

Thanks, @dougwilson!

@JamesMGreene JamesMGreene deleted the fix_rolling_uninit_combo branch December 15, 2015 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants