Skip to content

baseUrlField #262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 10 commits into
base: master
Choose a base branch
from
Open

baseUrlField #262

wants to merge 10 commits into from

Conversation

hezedu
Copy link

@hezedu hezedu commented Jan 27, 2016

It's really useful。

var ctrl_sess = session({
  secret: 'abc',
  cookie: {
    httpOnly: true,
    baseUrlField: true
  }
});
app.use('/:corpid', ctrl_sess);

@hezedu
Copy link
Author

hezedu commented Mar 15, 2016

I think The role of equal subdomain

# Conflicts:
#	HISTORY.md
#	README.md
#	package.json
#	test/session.js
@hezedu
Copy link
Author

hezedu commented May 29, 2017

Hi! Bro, It's been a year, I still use my fork. Let's merge it. pls.

@dougwilson
Copy link
Contributor

Hi @hezedu I'm sorry this PR has been left to rot. I am trying to get it rebased to get it landed, though, I guess better late than never.

I'm not able to rebase the PR, though:

 ! [remote rejected] pr-262 -> master (permission denied)
error: failed to push some refs to '[email protected]:hezedu/base_url_session.git'

Can you check the box so I can push? https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork

@hezedu
Copy link
Author

hezedu commented Oct 9, 2019

It's too long. I don't use my fork anymore and delete it.
It adds only three lines:
880fe48

You can do it by youself.

@dougwilson dougwilson force-pushed the master branch 2 times, most recently from 9d2e29b to 408229e Compare January 28, 2024 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants