-
-
Notifications
You must be signed in to change notification settings - Fork 987
Add promise support for sessionStore functions #635
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add promise support for sessionStore functions #635
Conversation
6e29589
to
ca343bd
Compare
ca343bd
to
44cc8d1
Compare
44cc8d1
to
63f0b88
Compare
63f0b88
to
c687d5a
Compare
@dougwilson I can add the |
Hey, so I added a couple more conditions on Monday to further bump the coverage to help out 👍Feel free to add some new ones as well; I just pushed up without the rebase on Monday just in case you were working on some as well. I took a look at the coveralls config and it's set only to care about line coverage. So I wouldn't really worry about the |
How would you recommend testing https://coveralls.io/builds/21919265/source?filename=index.js#L385? |
9d2e29b
to
408229e
Compare
Potential solution to #607.
I can add some more tests to improve coverage if necessary.