Skip to content

Conversation

@kakserpom
Copy link
Contributor

Implements #199

@kakserpom kakserpom force-pushed the 199_union_intersection_dnf branch 7 times, most recently from eee5f3d to 37e2e32 Compare December 23, 2025 14:50
@coveralls
Copy link

coveralls commented Dec 23, 2025

Pull Request Test Coverage Report for Build 20557543062

Details

  • 42 of 421 (9.98%) changed or added relevant lines in 5 files are covered.
  • 3 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-2.1%) to 33.693%

Changes Missing Coverage Covered Lines Changed/Added Lines %
crates/macros/src/impl_.rs 0 5 0.0%
src/args.rs 30 82 36.59%
src/zend/_type.rs 0 135 0.0%
crates/macros/src/function.rs 7 194 3.61%
Files with Coverage Reduction New Missed Lines %
crates/macros/src/impl_.rs 1 11.11%
src/args.rs 2 62.26%
Totals Coverage Status
Change from base Build 20556324797: -2.1%
Covered Lines: 1841
Relevant Lines: 5464

💛 - Coveralls

@kakserpom kakserpom force-pushed the 199_union_intersection_dnf branch 4 times, most recently from 6d96b6e to 9b56970 Compare December 28, 2025 12:01
Comment on lines +156 to +158
You can declare these complex types using the `#[php(types = "...")]` attribute
on parameters. The parameter type should be `&Zval` since Rust cannot directly
represent these union/intersection types.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could probably represent union types as rust enums. Same for intersection types were all elements are traits.

But that is something we can consider for a later iteration.

@kakserpom kakserpom force-pushed the 199_union_intersection_dnf branch from 9b56970 to 27f3f4c Compare December 28, 2025 18:02
@kakserpom kakserpom force-pushed the 199_union_intersection_dnf branch from 27f3f4c to 22f012e Compare December 28, 2025 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants