feat(class): readonly and final classes
#639
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kakserpom
force-pushed
the
readonly_class
branch
from
02a6b3e to
ec069a1
Compare
Pull Request Test Coverage Report for Build 20553374853Details
💛 - Coveralls |
Xenira
requested changes
Dec 27, 2025
Member
Xenira
left a comment
Xenira
left a comment
There was a problem hiding this comment.
Looks good, thanks. Just a small adjustment.
kakserpom
force-pushed
the
readonly_class
branch
6 times, most recently
from
9505f72 to
416e8ce
Compare
Xenira
requested changes
Dec 27, 2025
Member
Xenira
left a comment
Xenira
left a comment
There was a problem hiding this comment.
Think we can re-use the build utility for the test crate as well.
kakserpom
force-pushed
the
readonly_class
branch
5 times, most recently
from
8a3f06d to
cadacb4
Compare
kakserpom
force-pushed
the
readonly_class
branch
from
cadacb4 to
d3733fc
Compare
Xenira
reviewed
Dec 28, 2025
| repository = "https://github.com/extphprs/ext-php-rs" | ||
| homepage = "https://ext-php.rs" | ||
| license = "MIT OR Apache-2.0" | ||
| links = "ext-php-rs" |
Member
There was a problem hiding this comment.
linking with itself seems wrong. Havent looked into it though.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.