Exclude development scripts from published package#257
Exclude development scripts from published package#257pksunkara merged 3 commits intoeyre-rs:masterfrom
Conversation
During a dependency review we noticed that the color-eyre crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the `[bans.build.interpreted]` option of cargo deny. I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice. I decided to apply the settings to all workspace crates to make sure it similar issues won't happen for the other crates in the future.
|
cc @pksunkara as you merged PR's here: Any chance to get your look at this? |
pksunkara
left a comment
There was a problem hiding this comment.
I don't think I have permissions to force merge over test failures (even though they are caused by other issues).
But I will make this as approved in case they are fixed and then immediately merge this.
|
Let me see if I can get them passing this week and send a PR. Since @Manishearth is also made a contributor, he can approve and we will be able to get the fixes merged. |
ef3b8e7 to
c705e2e
Compare
d3da905 to
dc7db55
Compare
|
Most of the CI should now pass. The nightly CI is still broken as the backtrace format changed there, which breaks the following tests:
These seem to try to verify that the backtrace in a specific format but exactly that format changes because the compiler now returns something different. Might be related to symbol mangling or something like that. For reference for It currently gets For the It gets the following: |
Also bump a bunch of other dependencies + fix a few clippy warnings
dc7db55 to
e6a1240
Compare
During a dependency review we noticed that the color-eyre crate includes various development scripts. These development scripts shouldn't be there as they might, at some point become problematic. As of now they prevent any downstream user from enabling the
[bans.build.interpreted]option of cargo deny.I opted for using an explicit include list instead of an exclude list to prevent these files from being included in the published packages to make sure that everything that's included is an conscious choice. I decided to apply the settings to all workspace crates to make sure it similar issues won't happen for the other crates in the future.