Skip to content

Conversation

@djensenius
Copy link

I went to add some of these themes to my repo and noticed that they don't pass my linting rules. I figured I'd contribute back with some quick linting fixes and a GitHub workflow to test.

Copy link
Member

@gierens gierens left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! This is definitely a good idea! ... I left a few comments.

@@ -0,0 +1,16 @@
---
name: 'Lint YAML'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd call this lint.

- pull_request
jobs:
yamllint:
name: 'Lint YAML'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This I'd call yamllint.

# Custom filename-based overrides
# Cargo.toml: {icon: {glyph: 🦀}}
# Custom filename-based overrides
# Cargo.toml: {icon: {glyph: 🦀}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In these cases the indentation is intentional as you would just need to uncomment the example code and it would already be at the right indentation level. So this and other similar comments should stay this way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants