chore: add library icon for *.a and *.lib#1317
Closed
Freed-Wu wants to merge 1 commit intoeza-community:mainfrom
Freed-Wu:lib
Closed
chore: add library icon for *.a and *.lib#1317Freed-Wu wants to merge 1 commit intoeza-community:mainfrom Freed-Wu:lib
Freed-Wu wants to merge 1 commit intoeza-community:mainfrom
Freed-Wu:lib
Conversation
bare metal programs also use *.lib and *.a as their static library extension use linux icon is not appropriate
PThorpe92
reviewed
Feb 13, 2025
| "djv" => Icons::DOCUMENT, // | ||
| "djvu" => Icons::DOCUMENT, // | ||
| "dll" => Icons::LIBRARY, // | ||
| "dll" => Icons::OS_WINDOWS, // |
Member
There was a problem hiding this comment.
It's a windows specific file extension but still a library, not sure about this one
Member
There was a problem hiding this comment.
I agree, this should probably be changed the library icon
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
**chore: add library icon for .a and .lib
Description
How Has This Been Tested?