-
-
Couldn't load subscription status.
- Fork 338
feat(windows): report executable files #1318
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
0d2a963 to
78d967d
Compare
|
FreeBSD tests are failing due to clippy issues that this PR among other things fixes: #1327 |
|
I rebased main and thus also added a fix for the FreeBSD pipeline ... CI should be green now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems like a definite improvement over the current behavior, thanks!
OnceLock shouldn't incur a performance penalty if I remember correctly, right? ... Have you validated that? I don't have Windows, so I can't test it. On Linux I would've done something like this:
cargo build --release && hyperfine -w 500 -r 500 '{cmd} -l /usr/bin' --parameter-list cmd ./target/release/eza,eza --time-unit microsecond -N|
I replaced OnceLock for Lazy, which can be further replaced for LazyLock as stated here, because the official document seems prefer LazyLock in simple cases As for performance, I don't see much difference. As Windows I/O performance is bad comparing to *nix ( with antivirus running the performance is even MUCH worse ), I/O is always the bottleneck. |
|
Addressed @ariasuni's feedback and replaced Lazy for LazyLock. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since performance seems to be fine, LGTM! Thanks!
|
Conflicts resolved. Any chance to get reviewed? @cafkafk |
$PATHEXTis an Environment Variable that stores a list of the file extensions for operation system to execute. A file is considered executable if its extension matches$PATHEXT