feat(icon): update YAML icon to be more intuitive#1349
feat(icon): update YAML icon to be more intuitive#1349jlevy wants to merge 1 commit intoeza-community:mainfrom
Conversation
nf-seti-yml \u{e6a8} ()
->
fa-bars_staggered \u{ee19} ()
2b9114e to
0e544f7
Compare
cafkafk
left a comment
There was a problem hiding this comment.
I don't think we should move away from what nerdfonts thinks is a yml icon, even if it's a bad icon, that problem should be solved upstream. I do see why its confusing, but this will be the default for all nerdfont users across applicaitons even those that aren't eza, and we should stick with ecosystem consistency
|
@cafkafk yeah for sure, I understand that it would be best if this were solved upstream. However, it looks like the original "nf-seti-yml" source is from this old Atom theme. Nerd Fonts just imports various glyphs from known sources using their original names, so I'd expect it wouldn't make sense for Nerd Fonts to make any change to the icon or name. What we'd ideally want is a project/repo where file types are assigned icons, but I'm not sure a comprehensive one exists? The closest thing to that currently might be eza. :) Update: On looking a little further I see that even though it was for Atom originally, the seti-ui theme is maintained as it is used in VSCode. So perhaps you're right, and seti-ui/vscode should be the source of truth for file icons in the ecosystem, at least for the subset VSCode covers. See jesseweed/seti-ui#672 |
Considering we seem to agree here, it probably makes sense to close this for now. It does always feel a bit rude to do thou, so just to be clear, if we ever wanna change this again that's obviously always an option! |
After seeing this issue I realized I wasn't the only one confused by the oddity of the YAML icon being an exclamation point.
The best alternative I see in NF is the staggered bars, which evoke the structure of YAML slightly and aren't used for any other file types.
nf-seti-yml \u{e6a8} ()
->
fa-bars_staggered \u{ee19} ()