Skip to content

feat(icon): update YAML icon to be more intuitive#1349

Closed
jlevy wants to merge 1 commit intoeza-community:mainfrom
jlevy:change-yaml-icon
Closed

feat(icon): update YAML icon to be more intuitive#1349
jlevy wants to merge 1 commit intoeza-community:mainfrom
jlevy:change-yaml-icon

Conversation

@jlevy
Copy link

@jlevy jlevy commented Jan 24, 2025

After seeing this issue I realized I wasn't the only one confused by the oddity of the YAML icon being an exclamation point.

The best alternative I see in NF is the staggered bars, which evoke the structure of YAML slightly and aren't used for any other file types.

nf-seti-yml \u{e6a8} ()
->
fa-bars_staggered \u{ee19} ()

nf-seti-yml \u{e6a8} ()
->
fa-bars_staggered \u{ee19} ()
@jlevy jlevy changed the title Change YAML icon to be more intuitive. feat(icon): update YAML icon to be more intuitive Jan 24, 2025
Copy link
Member

@cafkafk cafkafk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we should move away from what nerdfonts thinks is a yml icon, even if it's a bad icon, that problem should be solved upstream. I do see why its confusing, but this will be the default for all nerdfont users across applicaitons even those that aren't eza, and we should stick with ecosystem consistency

@jlevy
Copy link
Author

jlevy commented Feb 4, 2025

@cafkafk yeah for sure, I understand that it would be best if this were solved upstream.

However, it looks like the original "nf-seti-yml" source is from this old Atom theme. Nerd Fonts just imports various glyphs from known sources using their original names, so I'd expect it wouldn't make sense for Nerd Fonts to make any change to the icon or name.

What we'd ideally want is a project/repo where file types are assigned icons, but I'm not sure a comprehensive one exists? The closest thing to that currently might be eza. :)

Update: On looking a little further I see that even though it was for Atom originally, the seti-ui theme is maintained as it is used in VSCode. So perhaps you're right, and seti-ui/vscode should be the source of truth for file icons in the ecosystem, at least for the subset VSCode covers. See jesseweed/seti-ui#672

@cafkafk
Copy link
Member

cafkafk commented Apr 19, 2025

Update: On looking a little further I see that even though it was for Atom originally, the seti-ui theme is maintained as it is used in VSCode. So perhaps you're right, and seti-ui/vscode should be the source of truth for file icons in the ecosystem, at least for the subset VSCode covers. See jesseweed/seti-ui#672

Considering we seem to agree here, it probably makes sense to close this for now. It does always feel a bit rude to do thou, so just to be clear, if we ever wanna change this again that's obviously always an option!

@cafkafk cafkafk closed this Apr 19, 2025
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in Eza Pull-Requests Apr 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

No open projects
Status: ✅ Done

Development

Successfully merging this pull request may close these issues.

2 participants