1.upgrade rust to 1.85.0. 2. add wildmatch to the path #1393
Conversation
awol2005ex
requested review from
MartinFillon,
PThorpe92,
gierens and
cafkafk
as code owners
There was a problem hiding this comment.
The wildmatch thing looks interesting, thanks, but could you please explain how this exactly improves things, is it about performance or about behavior and a specific example where it improves it. Also a short performance comparison with hyperfine would be nice.
About the MSRV change: The reason we are trailing Rust stable by several versions as many other projects like bat do as well, is that not all systems can install the latest rust version via rustup for example and thus would not be able to build eza if we would use the latest version. Also, I saw you opened a similar PR for bat: sharkdp/bat#3216 . So while I would lean towards no, we are not upgrading the MSRV to 1.85 now, I would also like to hear first what the bat team has to say about this.
Last but not least, while this PR should actually be two PRs, it should at least split the different things (wildmatch and msrv) into separate commits that also follow conventional commit format.
I want to do like that : eza -l E:\workspace* and show the folder like E:\workspace_node ,E:\workspace_java ,E:\workspace_rust .... |
1.upgrade rust to 1.85.0. 2. add wildmatch to the path