feat: add --spacing parameter #1558

marcosmoura · 2025-07-17T14:03:36Z

This adds a --spacing parameter to the cli. This is related to #520.

Initially I thought of adding the parameter as --space-between-columns, but the name seemed to be too long to be typed all the time.

Simple

Before:

After:

Long

Before:

After:

MartinFillon

Hi, thanks for your contribution. This is indeed a great idea and a really useful one to clarify output. I made some comments feel free to discuss them if you want. I will add two more general ones, first if you could cleanup the commit history so that we can understand more what happenned. I dont think you need to squash everything into one but maybe separate into the different parties. Also for the tests, the one you wrote yourself need to have a stdout and stderr file I believe (please tell me if I am wrong). And you will need to generate and update the powertest, for this I would recommend installing https://github.com/eza-community/powertest and using our Justfile. If you have any questions or need help feel free to ask

src/options/view.rs

src/output/mod.rs

marcosmoura · 2025-07-22T15:36:56Z

Hi, thanks for your contribution. This is indeed a great idea and a really useful one to clarify output. I made some comments feel free to discuss them if you want. I will add two more general ones, first if you could cleanup the commit history so that we can understand more what happenned. I dont think you need to squash everything into one but maybe separate into the different parties. Also for the tests, the one you wrote yourself need to have a stdout and stderr file I believe (please tell me if I am wrong). And you will need to generate and update the powertest, for this I would recommend installing eza-community/powertest and using our Justfile. If you have any questions or need help feel free to ask

@MartinFillon
I made a few changes based on your comments. How does it look now?
Rust is def not my strongest suit, so in case something is not right, let me know. :)

Edit: rewrote the whole commit history for a better understanding

MartinFillon

Thats some great work you did there. I dont have any complaints based on the code. Now as I said you still need to update the ptests. If you need help on how to as my previous comment might not be the best I can provide some. You will also need to sort out the CI not passing, I would recommend for that to use nix but if you have trouble please ask for help !

marcosmoura · 2025-07-23T18:12:16Z

Thats some great work you did there. I dont have any complaints based on the code. Now as I said you still need to update the ptests. If you need help on how to as my previous comment might not be the best I can provide some. You will also need to sort out the CI not passing, I would recommend for that to use nix but if you have trouble please ask for help !

@MartinFillon

I'm having several issues trying to run nix locally on macOS, especially when running just itest.
sudo and fd is not working, even if I install it using nativeBuildInputs.

Unfortunately, I don't have time to keep debugging this. Could you help me with that?

membphis · 2025-08-02T12:32:10Z

README.md


 </div>
-    
+


some changing is unrelated to this PR feat: add --spacing parameter

we'd better submit those commit in a separate PR

membphis · 2025-08-02T12:32:20Z

README.md

 Check out the themes available in the official [eza-themes](https://github.com/eza-community/eza-themes) repository, or contribute your own.

-An example theme file is available in `docs/theme.yml`, and needs to either be placed in a directory specified by the 
+An example theme file is available in `docs/theme.yml`, and needs to either be placed in a directory specified by the


membphis · 2025-08-02T12:32:36Z

README.md


-If you wanna contribute to eza, firstly, you're expected to follow our 
-[code of conduct](https://github.com/eza-community/eza/blob/main/CODE_OF_CONDUCT.md). 
+If you wanna contribute to eza, firstly, you're expected to follow our


membphis · 2025-08-02T12:33:14Z

completions/nush/eza.nu

    --treat-dirs-as-files(-d)  # List directories like regular files
    --level(-L): string        # Limit the depth of recursion
    --width(-w)                # Limits column output of grid, 0 implies auto-width
+    --spacing              # Space between columns in grid mode


Suggested change

--spacing # Space between columns in grid mode

--spacing # Space between columns in grid mode

cafkafk

Just a quick review, haven't read all of the code (i.e., there will likely be a more detailed review of that later).

I think before anything my primary concern here is that it seems even cargo test fails according to CI.

cafkafk · 2025-08-04T09:04:54Z

completions/fish/eza.fish

 complete -c eza -l git-ignore -d "Ignore files mentioned in '.gitignore'"
 complete -c eza -s a -l all -d "Show hidden and 'dot' files. Use this twice to also show the '.' and '..' directories"
-complete -c eza -s A -l almost-all -d "Equivalent to --all; included for compatibility with `ls -A`"
+complete -c eza -s A -l almost-all -d "Equivalent to --all; included for compatibility with $(ls -A)"


Not sure I understand why the $() is nescesarry here?

cafkafk · 2025-08-04T09:06:26Z

completions/zsh/_eza

        {-f,--only-files}"[List only files]" \
        {-L,--level}"+[Limit the depth of recursion]" \
        {-w,--width}"+[Limits column output of grid, 0 implies auto-width]" \
+        --spacing"+[Set the space between columns]" \


I can't remember the zsh syntax but this does seem odd compared to other lines, why not --spacing"[Set ...]" \?

cafkafk · 2025-08-04T09:07:01Z

man/eza.1.md

 `-w`, `--width=COLS`
 : Set screen width in columns.

+`--spacing=COLS`


COLS should be something appropriate for the context, e.g. spacing

cafkafk · 2025-08-04T09:08:01Z

src/options/flags.rs

 pub static CLASSIFY:     Arg = Arg { short: Some(b'F'), long: "classify",        takes_value: TakesValue::Optional(Some(WHEN), "auto") };
 pub static DEREF_LINKS:  Arg = Arg { short: Some(b'X'), long: "dereference",     takes_value: TakesValue::Forbidden };
 pub static WIDTH:        Arg = Arg { short: Some(b'w'), long: "width",           takes_value: TakesValue::Necessary(None) };
+pub static SPACING:Arg = Arg { short: None,       long: "spacing", takes_value: TakesValue::Necessary(None) };


Should be formatted like adjacent lines

cafkafk · 2025-08-04T09:08:44Z

src/options/help.rs

  --no-user                  suppress the user field
  --no-time                  suppress the time field
-  --stdin                    read file names from stdin, one per line or other separator 
+  --stdin                    read file names from stdin, one per line or other separator


This change doesn't seem like it should be introduced in this pr

marcosmoura requested review from MartinFillon, PThorpe92 and cafkafk as code owners July 17, 2025 14:03

MartinFillon requested changes Jul 17, 2025

View reviewed changes

src/options/view.rs Show resolved Hide resolved

src/output/mod.rs Show resolved Hide resolved

MartinFillon added features › ui Arguments Relates to arguments parsing/modifying/Adding labels Jul 17, 2025

marcosmoura closed this Jul 22, 2025

marcosmoura force-pushed the main branch from d890f9b to 97f9f36 Compare July 22, 2025 16:07

marcosmoura added 5 commits July 22, 2025 18:14

feat: add --space-between-columns parameter

56e8b43

fix: rename param to --spacing

eab9e3d

fix: allow zero spacing

e744758

test: update tests and remove redundant ones

a35c7a3

fix: implement spacing values with enum for a mode descriptive code

387099f

marcosmoura reopened this Jul 22, 2025

marcosmoura requested a review from MartinFillon July 22, 2025 16:31

MartinFillon requested changes Jul 23, 2025

View reviewed changes

marcosmoura requested a review from MartinFillon July 29, 2025 12:20

membphis reviewed Aug 2, 2025

View reviewed changes

cafkafk requested changes Aug 4, 2025

View reviewed changes

Delapouite mentioned this pull request Aug 23, 2025

feat: Adjustable Column Spacing #1003

Open

cafkafk linked an issue Sep 6, 2025 that may be closed by this pull request

feat: Adjustable Column Spacing #1003

Open

	--spacing # Space between columns in grid mode
	--spacing # Space between columns in grid mode

Uh oh!

Uh oh!

feat: add --spacing parameter #1558

Are you sure you want to change the base?

feat: add --spacing parameter #1558

Uh oh!

Conversation

marcosmoura commented Jul 17, 2025

Simple

Long

Uh oh!

MartinFillon left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

marcosmoura commented Jul 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

MartinFillon left a comment

Choose a reason for hiding this comment

Uh oh!

marcosmoura commented Jul 23, 2025

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cafkafk left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

marcosmoura commented Jul 22, 2025 •

edited

Loading