Skip to content

Conversation

@glye
Copy link
Member

@glye glye commented Dec 11, 2024

🎫 Issue IBX-9321

Description:

Bumped GH action version as old versions will be disabled soon.

@glye
Copy link
Member Author

glye commented Dec 11, 2024

Tests are failing, but they have been failing for a while in this repo. Seems not caused by this PR.

@adamwojs
Copy link
Member

You can regenerate phpstan baseline in follow up PR

@adamwojs adamwojs merged commit be3ca7e into 1.3 Dec 11, 2024
6 of 11 checks passed
@alongosz alongosz deleted the ibx9321_bump_github_action branch December 13, 2024 11:08
@glye
Copy link
Member Author

glye commented Dec 13, 2024

For the record, I had a look at the phpstan baseline. Based on the confluence doc I ended up with 3 un-ignorable errors:

Ignored error pattern #^Parameter \#1 \$filename of function file_put_contents expects string, string\|false given\.$# in path src/lib/FieldTypeProcessor/BinaryInputProcessor.php was not matched in reported errors.

Ignored error pattern #^Parameter \#2 \$string of function explode expects string, string\|null given\.$# in path src/lib/Server/Controller/Content.php is expected to occur 1 time, but occurred 4 times.

Ignored error pattern #^Parameter \#1 \$directory of function mkdir expects string, string\|false given\.$# in path tests/lib/FieldTypeProcessor/BinaryInputProcessorTest.php was not matched in reported errors.

How Andrew handled it in 4.6: ibexa/rest#141
Will need to get back to this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

6 participants