Added script for fixing var_dir issues for images

[mateuszbieniek]

This is port of legacy script that fixes images var_dir issues.

[mateuszbieniek]

Open questions:

1. Should this script have the option to move files to new var_dir?
2. Should this script clear cache at the end, or just inform the user that cache has to be cleared?

[andrerom]

So side comment, but with this, re-index command and probably also others, maybe we can find a way to expose reusable code for parallel processes? So one place where we can make sure any global arguments like siteaccess, debug, env, memory, ... is passed to php & bin/console.

Same goes for installers and need to run sub commands, like in Commerce installer PR.

WDYT @adamwojs @alongosz ?

[alongosz]

So side comment, but with this, re-index command and probably also others, maybe we can find a way to expose reusable code for parallel processes? So one place where we can make sure any global arguments like siteaccess, debug, env, memory, ... is passed to php & bin/console.

Same goes for installers and need to run sub commands, like in Commerce installer PR.

Yeah, this seems to be very repetitive.

[glye]

No blockers from me.

1. Move files? No. Minimise what it does. Admins may feel safer moving stuff themselves with regular file commands. Besides, if the script did the whole job, it would need a diffferent name :)
2. Clear cache? No. Again, minimise what it does, and let admin decide how and when to clear. But be very clear in info to admin.

[alongosz]

The direction here with a Gateway is good, however you need to apply it for all queries called directly from the Command. Otherwise you might end up having multiple transactions.

[alongosz]

This line tells me that you haven't tested this with Postgres ;) It won't work.

[alongosz]

Warning: this will stop working on upper branch. At this point I'd refactor Gateway itself, or decorate it just to be safe.

[mateuszbieniek]

Script has to be refactored slightly for 2.x and onward, so maybe w can leave it as it is and change it for "upper braches"?

[mateuszbieniek]

closed in favor: #2995