Skip to content

fix: support :has() and :only-child and modern pseudo-classes in ExtractStyleBlocks #488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ezyang wants to merge 2 commits into
base: master
Choose a base branch
from
+86 −4
Open

fix: support :has() and :only-child and modern pseudo-classes in ExtractStyleBlocks #488

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b7276c2
fix: support :has() and :only-child and modern pseudo-classes in Extr…
ezyang Aug 12, 2026
ecad0b5
fix: avoid shadowing media-query key in ExtractStyleBlocks
ezyang Aug 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
90 changes: 86 additions & 4 deletions library/HTMLPurifier/Filter/ExtractStyleBlocks.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,12 +67,54 @@ public function __construct()
$this->_class_attrdef = new HTMLPurifier_AttrDef_CSS_Ident();
$this->_enum_attrdef = new HTMLPurifier_AttrDef_Enum(
array(
'active',
'after',
'before',
'checked',
'default',
'defined',
'disabled',
'empty',
'enabled',
'first',
'first-child',
'first-letter',
'first-line',
'first-of-type',
'focus',
'focus-visible',
'focus-within',
'fullscreen',
'has',
'hover',
'in-range',
'indeterminate',
'invalid',
'lang',
'last-child',
'last-of-type',
'link',
'not',
'nth-child',
'nth-last-child',
'nth-last-of-type',
'nth-of-type',
'only-child',
'only-of-type',
'optional',
'out-of-range',
'placeholder-shown',
'read-only',
'read-write',
'required',
'root',
'scope',
'selection',
'target',
'valid',
'visited',
'active',
'hover',
'focus'
'where',
'is',
)
);
$this->_universal_attrdef = new HTMLPurifier_AttrDef_Enum(
Expand Down Expand Up @@ -247,7 +289,27 @@ public function cleanCSS($css, $config, $context)
}
} else {
// simple selector
$components = preg_split('/([#.:])/', $x, -1, PREG_SPLIT_DELIM_CAPTURE);
// Protect : inside functional pseudo parentheses (e.g. :has(br:only-child))
// so we don't split the inner selector
$x_protected = preg_replace_callback(
'/\([^)]*\)/',
function ($m) {
return str_replace(
array(':', '.', '#'),
array("\x01", "\x02", "\x03"),
$m[0]
);
},
$x
);
$components = preg_split('/([#.:])/', $x_protected, -1, PREG_SPLIT_DELIM_CAPTURE);
foreach ($components as $ck => $cv) {
$components[$ck] = str_replace(
array("\x01", "\x02", "\x03"),
array(':', '.', '#'),
$cv
);
}
$sdelim = null;
$nx = null;
for ($j = 0, $cc = count($components); $j < $cc; $j++) {
Expand All @@ -272,6 +334,26 @@ public function cleanCSS($css, $config, $context)
} elseif ($sdelim === '.') {
$attrdef = $this->_class_attrdef;
} elseif ($sdelim === ':') {
// Handle functional pseudo-classes like :has(), :not(), etc.
// These have parentheses with arguments, e.g. has(br:only-child)
$paren_pos = strpos($y, '(');
if ($paren_pos !== false) {
$func_name = substr($y, 0, $paren_pos);
$func_attrdef = $this->_enum_attrdef;
$func_r = $func_attrdef->validate($func_name, $config, $context);
if ($func_r !== false) {
// Functional pseudo is allowed, keep whole value
// e.g. has(br:only-child) -> valid if has is allowed
if ($nx === null) {
$nx = '';
}
$nx .= $sdelim . $y;
continue;
} else {
// Function not allowed, skip this pseudo
continue;
}
}
$attrdef = $this->_enum_attrdef;
} else {
throw new HTMLPurifier_Exception('broken invariant sdelim and preg_split');
Expand Down
Loading